Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1380617
| Path | csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Arnd Bergmann <arnd@arndb.de> |
| Newsgroups | linux.kernel |
| Subject | [PATCH] ixgbe: use msleep for long delays |
| Date | Sat, 16 Apr 2016 22:40:01 +0200 |
| Message-ID | <roFax-WA-5@gated-at.bofh.it> (permalink) |
| X-Original-To | Jeff Kirsher <jeffrey.t.kirsher@intel.com> |
| X-Mailer | git-send-email 2.7.0 |
| X-Provags-ID | V03:K0:MEYvR4pKzOlLo8nRXk7LdLj8tvIXlSVuSEORCn8LMXI0+pT539G dlN7CxtOkxgKMVrJsRn7gef2Ix4mb4Avg4kDRssIkkxg+fUyGpZ0wzv5n0hRl8epDSBfmdf OmUSL4c/JQaQjtqhkbXLS/uwu1pLuOtsSYBfO7p6va7HUrLfv6Gum3RMiLd28phdSqpEkk+ vQdmGV/ulL9qZ7g3kxybw== |
| X-Ui-Out-Filterresults | notjunk:1;V01:K0:bVNQ2Sh9wnQ=:7n6kmxPizYGM3AKyESQmTq mXp5a2exExHg9glwheQH3kO9Bw/ra43WeY8OZQstII05cFh+cXU6UUNFDX7eSzC6UotWr2fcv lRb8yYyy3T3BOVzrLnTFzGP1NjFCpdBgXcxZoR1ys4LcY1ANnRp8ChdjiAvcJTMAzEhqS262q QDvgequM2aE4dpNeWDy8JgcYfNtqszufFRxfPK1OgC8LNPLHYm47RaAz2PUY7nhvFzMslfGYx IFiJ6XNsg0zHecQP8Z0LkrssWElK0Nw2r5uFKnmkPxHOMA12344XWkfj0VaUbXNeU7C+DSsrn O9FdPoPHGTh6XPQyyrfgSztYpEdVzxhllfvdbWzq99+89claS93CRPfBaSEuleCl1p1g7Wj6V FZMQufatWXUtn18xOO/iabGc9I4GTKg3dqUlHhRvhhowmTCtBp5IJnc4oUjnre4b3hR966kCX r4/m8Yxp1Q/U3UiKaRaXAMbhiT2xUZqj7crDXoN02Ce52jkvX7GeKNXBu3IA8On74TWs5IV0F X0+5OSegcJlJEptpKMtBF+lLxj2jEi7r840wYlBW9CKO3upVaUQSOUcG0+vYLkL2/Ya7x9eUR RcrsGIN6C9RA0sa/6ClWxNdW3xOyR74gul69UBaMETKK9BGai4oD3joUkug1vQVEnPuFrZ+qW 5f/zVWsNnuvdT0OgRRLzCsK9HYwQXSlfjepC4NvGOECSGiY4YazjaxiOd9YbnZ2+cDO0= |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 31 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Arnd Bergmann <arnd@arndb.de>, Jesse Brandeburg <jesse.brandeburg@intel.com>, Shannon Nelson <shannon.nelson@intel.com>, Carolyn Wyborny <carolyn.wyborny@intel.com>, Don Skidmore <donald.c.skidmore@intel.com>, Bruce Allan <bruce.w.allan@intel.com>, John Ronciak <john.ronciak@intel.com>, Mitch Williams <mitch.a.williams@intel.com>, Mark Rustad <mark.d.rustad@intel.com>, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org |
| X-Original-Date | Sat, 16 Apr 2016 22:35:08 +0200 |
| X-Original-Message-ID | <1460838941-1251989-1-git-send-email-arnd@arndb.de> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1380617 |
Show key headers only | View raw
The newly added x550em_a support causes a link failure on ARM because of
an overly long time passed into udelay():
ERROR: "__bad_udelay" [drivers/net/ethernet/intel/ixgbe/ixgbe.ko] undefined!
There are multiple variants of the ixgbe_acquire_swfw_sync_*() function,
and the other ones all use msleep(), so we can safely assume that all
callers are allowed to sleep, which makes msleep() a better replacement
than mdelay().
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 49425dfc7451 ("ixgbe: Add support for x550em_a 10G MAC type")
---
drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c
index c71e93ed4451..21c0fce47e15 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c
@@ -2765,7 +2765,7 @@ static s32 ixgbe_acquire_swfw_sync_x550em_a(struct ixgbe_hw *hw, u32 mask)
ixgbe_release_swfw_sync_X540(hw, hmask);
if (status != IXGBE_ERR_TOKEN_RETRY)
return status;
- udelay(FW_PHY_TOKEN_DELAY * 1000);
+ msleep(FW_PHY_TOKEN_DELAY);
}
return status;
--
2.7.0
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH] ixgbe: use msleep for long delays Arnd Bergmann <arnd@arndb.de> - 2016-04-16 22:40 +0200 Re: [PATCH] ixgbe: use msleep for long delays David Miller <davem@davemloft.net> - 2016-04-18 06:10 +0200
csiph-web