Re: [PATCH] devlink: fix devlink_sb_register prototype

From	Jiri Pirko <jiri@resnulli.us>
Newsgroups	linux.kernel
Subject	Re: [PATCH] devlink: fix devlink_sb_register prototype
Date	2016-04-16 23:10 +0200
Message-ID	<roFDz-1ov-3@gated-at.bofh.it> (permalink)
References	<roF0R-Ro-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Sat, Apr 16, 2016 at 10:27:06PM CEST, arnd@arndb.de wrote:
>The devlink shared buffer interface contains two different
>prototypes for devlink_sb_register, and the one that is
>used when NET_DEVLINK is disabled does not work:
>
>drivers/net/ethernet/mellanox/mlxsw/spectrum_buffers.c: In function 'mlxsw_sp_buffers_init':
>drivers/net/ethernet/mellanox/mlxsw/spectrum_buffers.c:547:9: error: too many arguments to function 'devlink_sb_register'
>  return devlink_sb_register(priv_to_devlink(mlxsw_sp->core), 0,
>
>This makes the two prototypes have the same argument list.
>
>Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>Fixes: bf7974710a40 ("devlink: add shared buffer configuration")

Already fixed by:

commit de33efd0fb7f923cd41671b1f743c3a0d44dd953
Author: Jiri Pirko <jiri@mellanox.com>
Date:   Fri Apr 15 09:17:08 2016 +0200

    devlink: fix sb register stub in case devlink is disabled

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] devlink: fix devlink_sb_register prototype Arnd Bergmann <arnd@arndb.de> - 2016-04-16 22:30 +0200
  Re: [PATCH] devlink: fix devlink_sb_register prototype Jiri Pirko <jiri@resnulli.us> - 2016-04-16 23:10 +0200

csiph-web