Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1380605

Re: [PATCH v2 1/5] phy: Add a driver for simple phy

Show all headers | View raw

On Thursday 14 April 2016 11:22:58 Kishon Vijay Abraham I wrote:
> 
> IMO simple-phy driver should be an independent driver and shouldn't export
> symbols. The dt binding for the simple phy device should be something like
> below where all the properties of the simple phy device should be in the
> binding documentation.
> usbphy {
>         compatible = "simple-phy";
>         phy-supply = <&supply>;
>         clocks = <&clock>;
>         reset = <&reset>;
> };
> 
> Anything that needs more than this shouldn't be a simple phy.

I think there are two aspects here:

a) I agree that a driver that matches "simple-phy" should only call
   the generic functions and not use any other properties.

b) Independent of that, I think that it makes a lot of sense to export
   those functions from the generic PHY subsystems so they can be
   called from drivers that are a little less generic, or that already
   have an established binding but need no other code.

	Arnd

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 1/5] phy: Add a driver for simple phy Arnd Bergmann <arnd@arndb.de> - 2016-04-16 22:00 +0200
  Re: [PATCH v2 1/5] phy: Add a driver for simple phy Kishon Vijay Abraham I <kishon@ti.com> - 2016-04-18 14:40 +0200
    Re: [PATCH v2 1/5] phy: Add a driver for simple phy Arnd Bergmann <arnd@arndb.de> - 2016-04-18 16:50 +0200

csiph-web