[PATCH] qla2xxx: rewrite code to avoid hitting gcc bug 70646

From	Denys Vlasenko <dvlasenk@redhat.com>
Newsgroups	linux.kernel
Subject	[PATCH] qla2xxx: rewrite code to avoid hitting gcc bug 70646
Date	2016-04-15 12:40 +0200
Message-ID	<ro9kn-1wo-41@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

More info here:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70646

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
CC: Himanshu Madhani <himanshu.madhani@qlogic.com>
CC: James Bottomley <James.Bottomley@HansenPartnership.com>
CC: qla2xxx-upstream@qlogic.com
CC: Josh Poimboeuf <jpoimboe@redhat.com>
CC: linux-scsi@vger.kernel.org
CC: linux-kernel@vger.kernel.org
---
 drivers/scsi/qla2xxx/qla_attr.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_attr.c
index 4dc06a13..2dd9c72 100644
--- a/drivers/scsi/qla2xxx/qla_attr.c
+++ b/drivers/scsi/qla2xxx/qla_attr.c
@@ -2003,9 +2003,14 @@ static void
 qla2x00_get_host_fabric_name(struct Scsi_Host *shost)
 {
 	scsi_qla_host_t *vha = shost_priv(shost);
+	/*
+	 * This can trigger gcc 4.9/5.3 bug.
+	 * See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70646
 	uint8_t node_name[WWN_SIZE] = { 0xFF, 0xFF, 0xFF, 0xFF, \
 		0xFF, 0xFF, 0xFF, 0xFF};
 	u64 fabric_name = wwn_to_u64(node_name);
+	 */
+	u64 fabric_name = (u64)(s64)-1; /* the same as above */
 
 	if (vha->device_flags & SWITCH_FOUND)
 		fabric_name = wwn_to_u64(vha->fabric_node_name);
-- 
1.8.1.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] qla2xxx: rewrite code to avoid hitting gcc bug 70646 Denys Vlasenko <dvlasenk@redhat.com> - 2016-04-15 12:40 +0200
  Re: [PATCH] qla2xxx: rewrite code to avoid hitting gcc bug 70646 James Bottomley <James.Bottomley@HansenPartnership.com> - 2016-04-15 16:50 +0200
    Re: [PATCH] qla2xxx: rewrite code to avoid hitting gcc bug 70646 Denys Vlasenko <dvlasenk@redhat.com> - 2016-04-15 21:00 +0200
      Re: [PATCH] qla2xxx: rewrite code to avoid hitting gcc bug 70646 James Bottomley <James.Bottomley@HansenPartnership.com> - 2016-04-15 21:10 +0200
        Re: [PATCH] qla2xxx: rewrite code to avoid hitting gcc bug 70646 Josh Poimboeuf <jpoimboe@redhat.com> - 2016-04-15 22:10 +0200
          Re: [PATCH] qla2xxx: rewrite code to avoid hitting gcc bug 70646 James Bottomley <James.Bottomley@HansenPartnership.com> - 2016-04-15 23:20 +0200
        Re: [PATCH] qla2xxx: rewrite code to avoid hitting gcc bug 70646 Denys Vlasenko <dvlasenk@redhat.com> - 2016-04-15 23:20 +0200
          Re: [PATCH] qla2xxx: rewrite code to avoid hitting gcc bug 70646 James Bottomley <James.Bottomley@HansenPartnership.com> - 2016-04-15 23:30 +0200

csiph-web