Re: [PATCH] media: saa7134 fix media_dev alloc error path to not free when alloc fails

From	Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] media: saa7134 fix media_dev alloc error path to not free when alloc fails
Date	2016-04-15 11:50 +0200
Message-ID	<ro8xY-Vv-3@gated-at.bofh.it> (permalink)
References	<rnStc-4TB-21@gated-at.bofh.it> <rnWGu-5f-13@gated-at.bofh.it> <rnXMe-UY-21@gated-at.bofh.it>
Organization	Samsung

Show all headers | View raw

Em Thu, 14 Apr 2016 16:18:17 -0600
Shuah Khan <shuah.kh@samsung.com> escreveu:

> On 04/14/2016 03:08 PM, Mauro Carvalho Chehab wrote:
> > Em Thu, 14 Apr 2016 10:31:20 -0600
> > Shuah Khan <shuahkh@osg.samsung.com> escreveu:
> >   
> >> media_dev alloc error path does kfree when alloc fails. Fix it to not call
> >> kfree when media_dev alloc fails.  
> > 
> > No need. kfree(NULL) is OK.  
> 
> Agreed.
> 
> > 
> > Adding a label inside a conditional block is ugly.  
> 
> In this case, if label is in normal path, we will see defined, but not
> used warnings when condition isn't defined. 

True, but we don't need a label here, as kfree() can be called with a null
pointer.

> We seem to have many such
> cases for CONFIG_MEDIA_CONTROLLER :(

We may try to address those media-controller dependent code latter on.

I have some ideas of adding some macros and helper functions to allow
getting rid of those ifdefs and not add extra code if !MEDIA_CONTROLLER,
but the better seems to first add MC support to ALSA and make the
enable/disable functions generic, and then cleanup the code to remove
those ifdefs.

> 
> thanks,
> -- Shuah
> 
> 

-- 
Thanks,
Mauro

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] media: saa7134 fix media_dev alloc error path to not free when alloc fails Shuah Khan <shuahkh@osg.samsung.com> - 2016-04-14 18:40 +0200
  Re: [PATCH] media: saa7134 fix media_dev alloc error path to not  free when alloc fails Mauro Carvalho Chehab <mchehab@osg.samsung.com> - 2016-04-14 23:10 +0200
    Re: [PATCH] media: saa7134 fix media_dev alloc error path to not free  when alloc fails Shuah Khan <shuah.kh@samsung.com> - 2016-04-15 00:20 +0200
      Re: [PATCH] media: saa7134 fix media_dev alloc error path to not  free when alloc fails Mauro Carvalho Chehab <mchehab@osg.samsung.com> - 2016-04-15 11:50 +0200

csiph-web