Re: [PATCH] pmem: fix BUG() error in pmem.h:48 on X86_32

From	Ross Zwisler <ross.zwisler@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] pmem: fix BUG() error in pmem.h:48 on X86_32
Date	2016-04-13 19:30 +0200
Message-ID	<rnwM2-4Jb-3@gated-at.bofh.it> (permalink)
References	<rngHg-8eN-3@gated-at.bofh.it> <rnlxg-49c-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Apr 12, 2016 at 10:24:25PM -0700, Dan Williams wrote:
> On Tue, Apr 12, 2016 at 5:10 PM, Toshi Kani <toshi.kani@hpe.com> wrote:
> > After 'commit fc0c2028135c ("x86, pmem: use memcpy_mcsafe()
> > for memcpy_from_pmem()")', probing a PMEM device hits the BUG()
> > error below on X86_32 kernel.
> >
> >  kernel BUG at include/linux/pmem.h:48!
> >
> > memcpy_from_pmem() calls arch_memcpy_from_pmem(), which is
> > unimplemented since CONFIG_ARCH_HAS_PMEM_API is undefined on
> > X86_32.
> >
> > Fix the BUG() error by adding default_memcpy_from_pmem().
> >
> > Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
> > Cc: Dan Williams <dan.j.williams@intel.com>
> > Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
> 
> Whoops, I'll add a 32-bit boot test to my release criteria.  Thanks Toshi!

Yep, this patch looks correct to me.

Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] pmem: fix BUG() error in pmem.h:48 on X86_32 Toshi Kani <toshi.kani@hpe.com> - 2016-04-13 02:20 +0200
  Re: [PATCH] pmem: fix BUG() error in pmem.h:48 on X86_32 Dan Williams <dan.j.williams@intel.com> - 2016-04-13 07:30 +0200
    Re: [PATCH] pmem: fix BUG() error in pmem.h:48 on X86_32 Ross Zwisler <ross.zwisler@linux.intel.com> - 2016-04-13 19:30 +0200

csiph-web