Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1378100
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 08/15] dmaengine: dw: revisit data_width property |
| Date | 2016-04-13 18:50 +0200 |
| Message-ID | <rnw9k-46a-5@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <re3zA-7cH-9@gated-at.bofh.it> <rnvmX-3u7-47@gated-at.bofh.it> <rnvwD-3Pk-23@gated-at.bofh.it> <rnvGh-3Tg-1@gated-at.bofh.it> <rnvPY-3Yt-25@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Wed, Apr 13, 2016 at 07:21:53PM +0300, Andy Shevchenko wrote: > On Wed, 2016-04-13 at 21:47 +0530, Vinod Koul wrote: > > On Wed, Apr 13, 2016 at 07:05:48PM +0300, Andy Shevchenko wrote: > > > The old is still supported and benefit is apparently in unifying > > > standard properties across the drivers. > > Hrmmm how is that? > The common usage for data-width property is "in bytes". And I like the > idea. I don't know why at all I chose to keep encoded value there in the > first place and no one commented at that time. I suppose because of > screwed device tree process. I think now it's better to follow some > standard / registered properties in new drivers. You're unfortunately still breaking compatibility with existing DTs using this property. Now, it does appear that there is very little use of this DMA controller on DT systems and judging by the somewhat odd compatible string and in tree DTs most of those are legacy so perhaps this isn't the end of the world but this isn't something that should be dismissed as a simple cleanup.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v3 08/15] dmaengine: dw: revisit data_width property Vinod Koul <vinod.koul@intel.com> - 2016-04-13 18:00 +0200
Re: [PATCH v3 08/15] dmaengine: dw: revisit data_width property Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-04-13 18:10 +0200
Re: [PATCH v3 08/15] dmaengine: dw: revisit data_width property Vinod Koul <vinod.koul@intel.com> - 2016-04-13 18:20 +0200
Re: [PATCH v3 08/15] dmaengine: dw: revisit data_width property Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-04-13 18:30 +0200
Re: [PATCH v3 08/15] dmaengine: dw: revisit data_width property Mark Brown <broonie@kernel.org> - 2016-04-13 18:50 +0200
Re: [PATCH v3 08/15] dmaengine: dw: revisit data_width property Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-04-15 14:50 +0200
csiph-web