Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1378057

Re: [PATCH] coresight: no need to do the forced type conversion

From Mathieu Poirier <mathieu.poirier@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH] coresight: no need to do the forced type conversion
Date 2016-04-13 17:50 +0200
Message-ID <rnvdg-3q8-13@gated-at.bofh.it> (permalink)
References <rnoYb-7qk-33@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 13 April 2016 at 03:09, lipengcheng <lipengcheng8@huawei.com> wrote:
> activated and enable are already unsigned type,
> no need to change them to unsigned.
>
> Signed-off-by: Li Pengcheng <lipengcheng8@huawei.com>
> Signed-off-by: Li Zhong <lizhong11@hisilicon.com>
> ---
>  drivers/hwtracing/coresight/coresight.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight.c b/drivers/hwtracing/coresight/coresight.c
> index bba9f3d..617574a 100644
> --- a/drivers/hwtracing/coresight/coresight.c
> +++ b/drivers/hwtracing/coresight/coresight.c
> @@ -538,7 +538,7 @@ static ssize_t enable_sink_show(struct device *dev,
>  {
>         struct coresight_device *csdev = to_coresight_device(dev);
>
> -       return scnprintf(buf, PAGE_SIZE, "%u\n", (unsigned)csdev->activated);
> +       return scnprintf(buf, PAGE_SIZE, "%u\n", csdev->activated);
>  }
>
>  static ssize_t enable_sink_store(struct device *dev,
> @@ -568,7 +568,7 @@ static ssize_t enable_source_show(struct device *dev,
>  {
>         struct coresight_device *csdev = to_coresight_device(dev);
>
> -       return scnprintf(buf, PAGE_SIZE, "%u\n", (unsigned)csdev->enable);
> +       return scnprintf(buf, PAGE_SIZE, "%u\n", csdev->enable);
>  }

Applied - thanks.
Mathieu

>
>  static ssize_t enable_source_store(struct device *dev,
> --
> 1.8.3.2
>

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] coresight: no need to do the forced type conversion lipengcheng <lipengcheng8@huawei.com> - 2016-04-13 11:10 +0200
  Re: [PATCH] coresight: no need to do the forced type conversion Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-04-13 17:50 +0200

csiph-web