Re: [PATCH v5 01/14] x86/boot: enumerate documentation for the x86 hardware_subarch

From	"Luis R. Rodriguez" <mcgrof@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 01/14] x86/boot: enumerate documentation for the x86 hardware_subarch
Date	2016-04-13 17:20 +0200
Message-ID	<rnuKd-3cP-9@gated-at.bofh.it> (permalink)
References	<rlOk2-4h2-3@gated-at.bofh.it> <rlOk2-4h2-19@gated-at.bofh.it> <rno26-6wg-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Apr 13, 2016 at 10:01:32AM +0200, Ingo Molnar wrote:
> > diff --git a/arch/x86/include/uapi/asm/bootparam.h b/arch/x86/include/uapi/asm/bootparam.h
> > index 329254373479..bf9fea2f4591 100644
> > --- a/arch/x86/include/uapi/asm/bootparam.h
> > +++ b/arch/x86/include/uapi/asm/bootparam.h
> > @@ -157,7 +157,42 @@ struct boot_params {
> >  	__u8  _pad9[276];				/* 0xeec */
> >  } __attribute__((packed));
> >  
> > -enum {
> > +/**
> > + * enum x86_hardware_subarch - x86 hardware subarchitecture
> 
> Could you add some prominent warning here, like:
> 
> > + * WARNING: the 'x86 subarch flag' is only used for legacy hacks, for platform
> > + *          features that are not easily enumerated or discoverable. You should
> > + *          not ever use this for new features.

With pleasure, added.

  Luis

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v5 01/14] x86/boot: enumerate documentation for the x86 hardware_subarch "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-04-09 01:50 +0200
  Re: [PATCH v5 01/14] x86/boot: enumerate documentation for the x86  hardware_subarch Ingo Molnar <mingo@kernel.org> - 2016-04-13 10:10 +0200
    Re: [PATCH v5 01/14] x86/boot: enumerate documentation for the x86  hardware_subarch "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-04-13 17:20 +0200

csiph-web