[tip:x86/asm] x86/extable: Add a comment about early exception handlers

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	tip-bot for Andy Lutomirski <tipbot@zytor.com>
Newsgroups	linux.kernel
Subject	[tip:x86/asm] x86/extable: Add a comment about early exception handlers
Date	Wed, 13 Apr 2016 13:50:05 +0200
Message-ID	<rnrt3-BH-85@gated-at.bofh.it> (permalink)
References	<rkeVj-5br-3@gated-at.bofh.it>
X-Original-To	linux-tip-commits@vger.kernel.org
Reply-To	hpa@zytor.com, pbonzini@redhat.com, bp@suse.de, mingo@kernel.org, kvm@vger.kernel.org, Xen-devel@lists.xen.org, arjan@linux.intel.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, peterz@infradead.org, tglx@linutronix.de, boris.ostrovsky@oracle.com, torvalds@linux-foundation.org, luto@kernel.org, bp@alien8.de
Git-Commit-ID	60a0e2039e3df6c0a2b896bd78af36ff36fb629c
X-Mailer	tip-git-log-daemon
Robot-ID	<tip-bot.git.kernel.org>
Robot-Unsubscribe	Contact <mailto:hpa@kernel.org> to get blacklisted from these emails
MIME-Version	1.0
Content-Transfer-Encoding	8bit
Content-Type	text/plain; charset=UTF-8
Content-Disposition	inline
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	55
Organization	linux.* mail to news gateway
X-Original-Cc	hpa@zytor.com, pbonzini@redhat.com, bp@suse.de, mingo@kernel.org, Xen-devel@lists.xen.org, kvm@vger.kernel.org, arjan@linux.intel.com, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, tglx@linutronix.de, peterz@infradead.org, boris.ostrovsky@oracle.com, torvalds@linux-foundation.org, luto@kernel.org, bp@alien8.de
X-Original-Date	Wed, 13 Apr 2016 04:46:52 -0700
X-Original-Message-ID	<tip-60a0e2039e3df6c0a2b896bd78af36ff36fb629c@git.kernel.org>
X-Original-References	<5f1dcd6919f4a5923959a8065cb2c04d9dac1412.1459784772.git.luto@kernel.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1377848

Show key headers only | View raw

Commit-ID:  60a0e2039e3df6c0a2b896bd78af36ff36fb629c
Gitweb:     http://git.kernel.org/tip/60a0e2039e3df6c0a2b896bd78af36ff36fb629c
Author:     Andy Lutomirski <luto@kernel.org>
AuthorDate: Mon, 4 Apr 2016 08:46:22 -0700
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 13 Apr 2016 11:37:47 +0200

x86/extable: Add a comment about early exception handlers

Borislav asked for a comment explaining why all exception handlers are
allowed early.

Signed-off-by: Andy Lutomirski <luto@kernel.org>
Reviewed-by: Borislav Petkov <bp@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Arjan van de Ven <arjan@linux.intel.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: KVM list <kvm@vger.kernel.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: xen-devel <Xen-devel@lists.xen.org>
Link: http://lkml.kernel.org/r/5f1dcd6919f4a5923959a8065cb2c04d9dac1412.1459784772.git.luto@kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/mm/extable.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/x86/mm/extable.c b/arch/x86/mm/extable.c
index fd9eb98..aaeda3f 100644
--- a/arch/x86/mm/extable.c
+++ b/arch/x86/mm/extable.c
@@ -125,6 +125,20 @@ void __init early_fixup_exception(struct pt_regs *regs, int trapnr)
 	if (regs->cs != __KERNEL_CS)
 		goto fail;
 
+	/*
+	 * The full exception fixup machinery is available as soon as
+	 * the early IDT is loaded.  This means that it is the
+	 * responsibility of extable users to either function correctly
+	 * when handlers are invoked early or to simply avoid causing
+	 * exceptions before they're ready to handle them.
+	 *
+	 * This is better than filtering which handlers can be used,
+	 * because refusing to call a handler here is guaranteed to
+	 * result in a hard-to-debug panic.
+	 *
+	 * Keep in mind that not all vectors actually get here.  Early
+	 * fage faults, for example, are special.
+	 */
 	if (fixup_exception(regs, trapnr))
 		return;

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] x86/extable: Add a comment about early exception handlers Andy Lutomirski <luto@kernel.org> - 2016-04-04 17:50 +0200
  Re: [PATCH] x86/extable: Add a comment about early exception handlers Borislav Petkov <bp@alien8.de> - 2016-04-04 18:20 +0200
  [tip:x86/asm] x86/extable: Add a comment about early exception  handlers tip-bot for Andy Lutomirski <tipbot@zytor.com> - 2016-04-13 13:50 +0200

csiph-web