Re: [PATCH] drm/nouveau/iccsense: fix ifnullfree.cocci warnings

From	Karol Herbst <nouveau@karolherbst.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drm/nouveau/iccsense: fix ifnullfree.cocci warnings
Date	2016-04-13 12:20 +0200
Message-ID	<rnq3U-8a8-19@gated-at.bofh.it> (permalink)
References	<rnn62-5Id-5@gated-at.bofh.it> <rnn62-5Id-3@gated-at.bofh.it> <rnnSp-69I-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


> Martin Peres <martin.peres@free.fr> hat am 13. April 2016 um 09:55
> geschrieben:
> 
> 
> On 13/04/16 10:07, kbuild test robot wrote:
> > drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c:133:2-7: WARNING: NULL
> > check before freeing functions like kfree, debugfs_remove,
> > debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider
> > reorganizing relevant code to avoid passing NULL values.
> >
> >   NULL check before some freeing functions is not needed.
> >
> >   Based on checkpatch warning
> >   "kfree(NULL) is safe this check is probably not required"
> >   and kfreeaddr.cocci by Julia Lawall.
> >
> > Generated by: scripts/coccinelle/free/ifnullfree.cocci
> >
> > CC: Karol Herbst <nouveau@karolherbst.de>
> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Martin Peres <martin.peres@free.fr>
Signed-off-by: Karol Herbst <nouveau@karolherbst.de>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] drm/nouveau/iccsense: fix ifnullfree.cocci warnings kbuild test robot <fengguang.wu@intel.com> - 2016-04-13 09:10 +0200
  Re: [PATCH] drm/nouveau/iccsense: fix ifnullfree.cocci warnings Martin Peres <martin.peres@free.fr> - 2016-04-13 10:00 +0200
    Re: [PATCH] drm/nouveau/iccsense: fix ifnullfree.cocci warnings Karol Herbst <nouveau@karolherbst.de> - 2016-04-13 12:20 +0200

csiph-web