Re: [PATCH] atmel-isc: fix compare_const_fl.cocci warnings

From	"Wu, Songjun" <songjun.wu@atmel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] atmel-isc: fix compare_const_fl.cocci warnings
Date	2016-04-13 11:30 +0200
Message-ID	<rnphv-7zX-3@gated-at.bofh.it> (permalink)
References	<rnoEO-6Uh-21@gated-at.bofh.it>
Organization	ATMEL

Show all headers | View raw

Accept.
Thank you for your comments.

On 4/13/2016 16:49, Julia Lawall wrote:
> Move constants to the right of binary operators.
>
> Generated by: scripts/coccinelle/misc/compare_const_fl.cocci
>
> CC: Songjun Wu <songjun.wu@atmel.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
>
> Up to you.  Seems a tiny bit more readable to me not to have ISC_DCTRL and
> ISC_DCTRL_IE_IS right together.
>
>   atmel-isc.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/media/platform/atmel/atmel-isc.c
> +++ b/drivers/media/platform/atmel/atmel-isc.c
> @@ -639,7 +639,7 @@ static inline void isc_start_dma(struct
>
>   	addr = vb2_dma_contig_plane_dma_addr(&frm->vb.vb2_buf, 0);
>
> -	regmap_write(regmap, ISC_DCTRL, ISC_DCTRL_IE_IS | dview);
> +	regmap_write(regmap, ISC_DCTRL, dview | ISC_DCTRL_IE_IS);
>   	regmap_write(regmap, ISC_DAD0, addr);
>   	regmap_update_bits(regmap, ISC_CTRLEN,
>   			   ISC_CTRLEN_CAPTURE_MASK, ISC_CTRLEN_CAPTURE);
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] atmel-isc: fix compare_const_fl.cocci warnings Julia Lawall <julia.lawall@lip6.fr> - 2016-04-13 10:50 +0200
  Re: [PATCH] atmel-isc: fix compare_const_fl.cocci warnings "Wu, Songjun" <songjun.wu@atmel.com> - 2016-04-13 11:30 +0200

csiph-web