Re: [PATCH V2 2/2] scripts: dtc: fix memory leak after realloc

From	David Gibson <david@gibson.dropbear.id.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH V2 2/2] scripts: dtc: fix memory leak after realloc
Date	2016-04-13 06:20 +0200
Message-ID	<rnkrv-3gi-1@gated-at.bofh.it> (permalink)
References	<rndzH-5be-9@gated-at.bofh.it> <rndzI-5be-23@gated-at.bofh.it> <rndT5-5HZ-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, Apr 12, 2016 at 04:11:17PM -0500, Rob Herring wrote:
> On Tue, Apr 12, 2016 at 3:55 PM, Maxim Zhukov
> <mussitantesmortem@gmail.com> wrote:
> > This commit fixed memory leak after errors realloc.
> >
> > Signed-off-by: Maxim Zhukov <mussitantesmortem@gmail.com>
> > ---
> >  scripts/dtc/fdtput.c | 10 +++++++---
> 
> Again, your patch is against the kernel copy of dtc. It needs to be
> against upstream dtc and then I can update the kernel copy once this
> lands.

Right.  TBH, I'm not particularly concerned about the leak anyway.
The memory will be freed when fdtput exits moments later, so it's
really not a big deal.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Thread

[PATCH V2 0/2] scripts: small fixes Maxim Zhukov <mussitantesmortem@gmail.com> - 2016-04-12 23:00 +0200
  [PATCH V2 2/2] scripts: dtc: fix memory leak after realloc Maxim Zhukov <mussitantesmortem@gmail.com> - 2016-04-12 23:00 +0200
    Re: [PATCH V2 2/2] scripts: dtc: fix memory leak after realloc Rob Herring <robh+dt@kernel.org> - 2016-04-12 23:20 +0200
      Re: [PATCH V2 2/2] scripts: dtc: fix memory leak after realloc David Gibson <david@gibson.dropbear.id.au> - 2016-04-13 06:20 +0200
  [PATCH V2 1/2] scripts: genksyms: fix resource leak Maxim Zhukov <mussitantesmortem@gmail.com> - 2016-04-12 23:00 +0200

csiph-web