Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1377492

Re: [PATCH 2/4] sched/fair: Drop out incomplete current period when sched averages accrue

From Yuyang Du <yuyang.du@intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH 2/4] sched/fair: Drop out incomplete current period when sched averages accrue
Date 2016-04-13 06:00 +0200
Message-ID <rnk89-2MV-1@gated-at.bofh.it> (permalink)
References <rmDmx-1gf-3@gated-at.bofh.it> <rmDmx-1gf-1@gated-at.bofh.it> <rn5iO-7dg-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Apr 12, 2016 at 01:02:58PM +0100, Dietmar Eggemann wrote:
> On 10/04/16 23:36, Yuyang Du wrote:
> 
> [...]
> 
> > @@ -2704,11 +2694,14 @@ static __always_inline int
> >  __update_load_avg(u64 now, int cpu, struct sched_avg *sa,
> >  		  unsigned long weight, int running, struct cfs_rq *cfs_rq)
> >  {
> > -	u64 delta, scaled_delta, periods;
> > -	u32 contrib;
> > -	unsigned int delta_w, scaled_delta_w, decayed = 0;
> > +	u64 delta;
> > +	u32 contrib, periods;
> >  	unsigned long scale_freq, scale_cpu;
> >  
> > +	/*
> > +	 * now rolls down to a period boundary
> > +	 */
> > +	now = now && (u64)(~0xFFFFF);
> 
> This forces now to be 1.
> 
> s/&&/&

Duh, :)

Thanks.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 2/4] sched/fair: Drop out incomplete current period when sched averages accrue Yuyang Du <yuyang.du@intel.com> - 2016-04-11 08:20 +0200
  Re: [PATCH 2/4] sched/fair: Drop out incomplete current period when  sched averages accrue Vincent Guittot <vincent.guittot@linaro.org> - 2016-04-11 11:10 +0200
    Re: [PATCH 2/4] sched/fair: Drop out incomplete current period when  sched averages accrue Yuyang Du <yuyang.du@intel.com> - 2016-04-12 05:30 +0200
      Re: [PATCH 2/4] sched/fair: Drop out incomplete current period when  sched averages accrue Vincent Guittot <vincent.guittot@linaro.org> - 2016-04-12 14:00 +0200
        Re: [PATCH 2/4] sched/fair: Drop out incomplete current period when  sched averages accrue Yuyang Du <yuyang.du@intel.com> - 2016-04-13 07:00 +0200
          Re: [PATCH 2/4] sched/fair: Drop out incomplete current period when  sched averages accrue Vincent Guittot <vincent.guittot@linaro.org> - 2016-04-13 13:20 +0200
  Re: [PATCH 2/4] sched/fair: Drop out incomplete current period when  sched averages accrue Dietmar Eggemann <dietmar.eggemann@arm.com> - 2016-04-12 14:10 +0200
    Re: [PATCH 2/4] sched/fair: Drop out incomplete current period when  sched averages accrue Yuyang Du <yuyang.du@intel.com> - 2016-04-13 06:00 +0200
      Re: [PATCH 2/4] sched/fair: Drop out incomplete current period when  sched averages accrue Joe Perches <joe@perches.com> - 2016-04-13 06:10 +0200
      Re: [PATCH 2/4] sched/fair: Drop out incomplete current period when  sched averages accrue Morten Rasmussen <morten.rasmussen@arm.com> - 2016-04-13 10:40 +0200
  Re: [PATCH 2/4] sched/fair: Drop out incomplete current period when  sched averages accrue Dietmar Eggemann <dietmar.eggemann@arm.com> - 2016-04-13 17:20 +0200
    Re: [PATCH 2/4] sched/fair: Drop out incomplete current period when  sched averages accrue Vincent Guittot <vincent.guittot@linaro.org> - 2016-04-13 17:30 +0200
      Re: [PATCH 2/4] sched/fair: Drop out incomplete current period when  sched averages accrue Vincent Guittot <vincent.guittot@linaro.org> - 2016-04-13 18:30 +0200
      Re: [PATCH 2/4] sched/fair: Drop out incomplete current period when  sched averages accrue Yuyang Du <yuyang.du@intel.com> - 2016-04-14 04:30 +0200
        Re: [PATCH 2/4] sched/fair: Drop out incomplete current period when  sched averages accrue Dietmar Eggemann <dietmar.eggemann@arm.com> - 2016-04-14 15:00 +0200
          Re: [PATCH 2/4] sched/fair: Drop out incomplete current period when  sched averages accrue Yuyang Du <yuyang.du@intel.com> - 2016-04-15 05:50 +0200

csiph-web