Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1377438
| From | Rob Herring <robh+dt@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v4 14/16] arm64: dts: hikey: Add hi655x pmic dts node |
| Date | 2016-04-13 02:20 +0200 |
| Message-ID | <rngHg-8eN-11@gated-at.bofh.it> (permalink) |
| References | <rngnU-7PD-3@gated-at.bofh.it> <rngxA-8aq-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Apr 12, 2016 at 6:55 PM, Guodong Xu <guodong.xu@linaro.org> wrote:
> From: Chen Feng <puck.chen@hisilicon.com>
>
> Add the mfd hi655x dts node and regulator support on hi6220 platform.
>
> Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
> Signed-off-by: Fei Wang <w.f@huawei.com>
> Signed-off-by: Xinwei Kong <kong.kongxinwei@hisilicon.com>
> Signed-off-by: Guodong Xu <guodong.xu@linaro.org>
> Reviewed-by: Haojian Zhuang <haojian.zhuang@linaro.org>
> Reviewed-by: Rob Herring <robh@kernel.org>
I did not provide a Reviewed-by. You cannot add people's Reviewed-by
just because they provided a review. It is only when the review is
finished that the reviewer will give it.
That being said, it looks fine now and you can add it.
> Acked-by: Lee Jones <lee.jones@linaro.org>
> ---
> arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 87 +++++++++++++++++++++++++-
> 1 file changed, 86 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> index b7c41f8..cc1148d 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> @@ -6,9 +6,9 @@
> */
>
> /dts-v1/;
> -
> #include "hi6220.dtsi"
> #include "hikey-pinctrl.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
>
> / {
> model = "HiKey Development Board";
> @@ -107,6 +107,91 @@
> default-state = "off";
> };
> };
> +
> + pmic: pmic@f8000000 {
> + compatible = "hisilicon,hi655x-pmic";
> + reg = <0x0 0xf8000000 0x0 0x1000>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + pmic-gpios = <&gpio1 2 GPIO_ACTIVE_HIGH>;
> +
> + regulators {
> + ldo2: LDO2 {
> + regulator-name = "LDO2_2V8";
> + regulator-min-microvolt = <2500000>;
> + regulator-max-microvolt = <3200000>;
> + regulator-enable-ramp-delay = <120>;
> + };
> +
> + ldo7: LDO7 {
> + regulator-name = "LDO7_SDIO";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-enable-ramp-delay = <120>;
> + };
> +
> + ldo10: LDO10 {
> + regulator-name = "LDO10_2V85";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <3000000>;
> + regulator-enable-ramp-delay = <360>;
> + };
> +
> + ldo13: LDO13 {
> + regulator-name = "LDO13_1V8";
> + regulator-min-microvolt = <1600000>;
> + regulator-max-microvolt = <1950000>;
> + regulator-enable-ramp-delay = <120>;
> + };
> +
> + ldo14: LDO14 {
> + regulator-name = "LDO14_2V8";
> + regulator-min-microvolt = <2500000>;
> + regulator-max-microvolt = <3200000>;
> + regulator-enable-ramp-delay = <120>;
> + };
> +
> + ldo15: LDO15 {
> + regulator-name = "LDO15_1V8";
> + regulator-min-microvolt = <1600000>;
> + regulator-max-microvolt = <1950000>;
> + regulator-boot-on;
> + regulator-always-on;
> + regulator-enable-ramp-delay = <120>;
> + };
> +
> + ldo17: LDO17 {
> + regulator-name = "LDO17_2V5";
> + regulator-min-microvolt = <2500000>;
> + regulator-max-microvolt = <3200000>;
> + regulator-enable-ramp-delay = <120>;
> + };
> +
> + ldo19: LDO19 {
> + regulator-name = "LDO19_3V0";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <3000000>;
> + regulator-enable-ramp-delay = <360>;
> + };
> +
> + ldo21: LDO21 {
> + regulator-name = "LDO21_1V8";
> + regulator-min-microvolt = <1650000>;
> + regulator-max-microvolt = <2000000>;
> + regulator-always-on;
> + regulator-enable-ramp-delay = <120>;
> + };
> +
> + ldo22: LDO22 {
> + regulator-name = "LDO22_1V2";
> + regulator-min-microvolt = <900000>;
> + regulator-max-microvolt = <1200000>;
> + regulator-boot-on;
> + regulator-always-on;
> + regulator-enable-ramp-delay = <120>;
> + };
> + };
> + };
> };
>
> &uart2 {
> --
> 1.9.1
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v4 00/16] DTS for hi6220 and HiKey Guodong Xu <guodong.xu@linaro.org> - 2016-04-13 02:00 +0200
[PATCH v4 12/16] arm64: dts: hi6220: add pinctrl for uarts and enable them Guodong Xu <guodong.xu@linaro.org> - 2016-04-13 02:00 +0200
[PATCH v4 06/16] arm64: dts: add Hi6220 spi configuration nodes Guodong Xu <guodong.xu@linaro.org> - 2016-04-13 02:00 +0200
[PATCH v4 13/16] arm64: dts: add LED nodes for hi6220-hikey Guodong Xu <guodong.xu@linaro.org> - 2016-04-13 02:00 +0200
[PATCH v4 08/16] arm64: dts: hikey: enable i2c0 and i2c1 for working with mezzanine boards Guodong Xu <guodong.xu@linaro.org> - 2016-04-13 02:00 +0200
[PATCH v4 07/16] arm64: dts: add all hi6220 i2c nodes Guodong Xu <guodong.xu@linaro.org> - 2016-04-13 02:00 +0200
[PATCH v4 09/16] arm64: dts: Add hi6220 usb node Guodong Xu <guodong.xu@linaro.org> - 2016-04-13 02:00 +0200
[PATCH v4 04/16] arm64: dts: Add Hi6220 gpio configuration nodes Guodong Xu <guodong.xu@linaro.org> - 2016-04-13 02:00 +0200
[PATCH v4 11/16] arm64: dts: add Hi6220's stub clock node Guodong Xu <guodong.xu@linaro.org> - 2016-04-13 02:00 +0200
[PATCH v4 10/16] arm64: dts: add mailbox node for Hi6220 Guodong Xu <guodong.xu@linaro.org> - 2016-04-13 02:00 +0200
[PATCH v4 05/16] arm64: dts: add Hi6220 pinctrl configuration nodes Guodong Xu <guodong.xu@linaro.org> - 2016-04-13 02:00 +0200
[PATCH v4 03/16] arm64: dts: enable idle states for Hi6220 Guodong Xu <guodong.xu@linaro.org> - 2016-04-13 02:00 +0200
[PATCH v4 15/16] arm64: dts: add dwmmc nodes for hi6220 Guodong Xu <guodong.xu@linaro.org> - 2016-04-13 02:10 +0200
[PATCH v4 16/16] arm64: dts: add wifi nodes support for hi6220-hikey Guodong Xu <guodong.xu@linaro.org> - 2016-04-13 02:10 +0200
[PATCH v4 14/16] arm64: dts: hikey: Add hi655x pmic dts node Guodong Xu <guodong.xu@linaro.org> - 2016-04-13 02:10 +0200
Re: [PATCH v4 14/16] arm64: dts: hikey: Add hi655x pmic dts node Rob Herring <robh+dt@kernel.org> - 2016-04-13 02:20 +0200
Re: [PATCH v4 14/16] arm64: dts: hikey: Add hi655x pmic dts node Guodong Xu <guodong.xu@linaro.org> - 2016-04-13 02:20 +0200
csiph-web