Re: [PATCH v6 0/6] Introduce GCC plugin infrastructure

From	Kees Cook <keescook@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 0/6] Introduce GCC plugin infrastructure
Date	2016-04-12 21:50 +0200
Message-ID	<rnctX-4hV-9@gated-at.bofh.it> (permalink)
References	<rlpvj-1uc-3@gated-at.bofh.it> <rnaBQ-2QL-13@gated-at.bofh.it> <rnbez-3s3-19@gated-at.bofh.it> <rnbxT-3BX-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Apr 12, 2016 at 11:41 AM, David Brown <david.brown@linaro.org> wrote:
> On Tue, Apr 12, 2016 at 11:27:52AM -0700, Kees Cook wrote:
>
>> Awesome! Thanks for testing this. I still need to finish getting my
>> arm64 environment built...
>
>
> I've been using:
>  http://releases.linaro.org/components/toolchain/binaries/
>
> for most stuff.
>
>> Do you happen to know if there's already a gcc bug open for the make
>> install problem?
>
>
> Linaro toolchain bug:
>  https://bugs.linaro.org/show_bug.cgi?id=2123
>
> Patch to fix it
>  https://gcc.gnu.org/ml/gcc-patches/2016-03/msg00522.html
>
> It is supposed to be included in the linaro 5.3-2016.03 snapshot.
> I've pinged Christophe to see if I can get any insight into when that
> will be available.

Looks like it's in the upstream tree:

https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=bfe972081c3c75019fa5a6e883dcbeb5e03eea18

I'm not sure how GCC does bug fix releases. Is this going to be in 5.4
or 5.3.1? (Is there such a thing as 5.3.1 planned?) I've CCed Jeff in
case he's got a moment to peek at this.

> It is kind of nice to see that when it fails, it prints a helpful
> message, though:
>
>  scripts/Makefile.gcc-plugins:22: *** error, your gcc installation does not
> support plugins, perhaps the necessary headers are missing?.  Stop.
>
> I think it is OK to include this, even with the patches still bubbling
> through gcc releases.  It prints a helpful message when it doesn't
> work, and is only going to be selected if specifically requested.

Yeah, absolutely. It works on the other architectures, and will soon
work on arm64 too.

-Kees

-- 
Kees Cook
Chrome OS & Brillo Security

Thread

[PATCH v6 0/6] Introduce GCC plugin infrastructure Emese Revfy <re.emese@gmail.com> - 2016-04-07 23:20 +0200
  [PATCH v6 3/6] The GCC plugin infrastructure supports the arm and  arm64 architectures too Emese Revfy <re.emese@gmail.com> - 2016-04-07 23:20 +0200
  [PATCH v6 4/6] Add Cyclomatic complexity GCC plugin Emese Revfy <re.emese@gmail.com> - 2016-04-07 23:20 +0200
  [PATCH v6 6/6] Add sancov plugin Emese Revfy <re.emese@gmail.com> - 2016-04-07 23:30 +0200
  [PATCH v6 5/6] Documentation for the GCC plugin infrastructure Emese Revfy <re.emese@gmail.com> - 2016-04-07 23:30 +0200
  Re: [PATCH v6 0/6] Introduce GCC plugin infrastructure David Brown <david.brown@linaro.org> - 2016-04-12 19:50 +0200
    Re: [PATCH v6 0/6] Introduce GCC plugin infrastructure Kees Cook <keescook@chromium.org> - 2016-04-12 20:30 +0200
      Re: [PATCH v6 0/6] Introduce GCC plugin infrastructure David Brown <david.brown@linaro.org> - 2016-04-12 20:50 +0200
        Re: [PATCH v6 0/6] Introduce GCC plugin infrastructure Kees Cook <keescook@chromium.org> - 2016-04-12 21:50 +0200
          Re: [PATCH v6 0/6] Introduce GCC plugin infrastructure "PaX Team" <pageexec@freemail.hu> - 2016-04-12 23:30 +0200
      Re: [PATCH v6 0/6] Introduce GCC plugin infrastructure Emese Revfy <re.emese@gmail.com> - 2016-04-12 21:00 +0200
        Re: [PATCH v6 0/6] Introduce GCC plugin infrastructure Kees Cook <keescook@chromium.org> - 2016-04-12 21:50 +0200
  Re: [PATCH v6 2/6] GCC plugin infrastructure Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-04-13 04:40 +0200

csiph-web