Re: [PATCH 4/4] x86/oprofile: down with test_thread_flag(TIF_IA32)

From	Andy Lutomirski <luto@amacapital.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/4] x86/oprofile: down with test_thread_flag(TIF_IA32)
Date	2016-04-14 21:40 +0200
Message-ID	<rnVho-7bz-19@gated-at.bofh.it> (permalink)
References	<rnU1X-6dp-3@gated-at.bofh.it> <rnU1X-6dp-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Apr 14, 2016 at 11:10 AM, Dmitry Safonov <dsafonov@virtuozzo.com> wrote:
> As we have here full register set - just use user_64bit_mode
> on it.
>
> Signed-off-by: Dmitry Safonov <dsafonov@virtuozzo.com>
> ---
>  arch/x86/oprofile/backtrace.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/oprofile/backtrace.c b/arch/x86/oprofile/backtrace.c
> index cb31a4440e58..405dadaee74a 100644
> --- a/arch/x86/oprofile/backtrace.c
> +++ b/arch/x86/oprofile/backtrace.c
> @@ -69,7 +69,7 @@ x86_backtrace_32(struct pt_regs * const regs, unsigned int depth)
>         struct stack_frame_ia32 *head;
>
>         /* User process is IA32 */
> -       if (!current || !test_thread_flag(TIF_IA32))
> +       if (!current || user_64bit_mode(regs))

This is presumably okay, but I know nothing about oprofile.

>                 return 0;
>
>         head = (struct stack_frame_ia32 *) regs->bp;
> --
> 2.8.0
>



-- 
Andy Lutomirski
AMA Capital Management, LLC

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 4/4] x86/oprofile: down with test_thread_flag(TIF_IA32) Dmitry Safonov <dsafonov@virtuozzo.com> - 2016-04-14 20:20 +0200
  Re: [PATCH 4/4] x86/oprofile: down with test_thread_flag(TIF_IA32) Andy Lutomirski <luto@amacapital.net> - 2016-04-14 21:40 +0200

csiph-web