Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1379141

System call number masking

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

I'm updating my x32-as-boot-time-option patch for 4.6, and I noticed a
subtle change in system call number masking on x86_64 as a result of
moving the slow path into C.

Previously we would mask out the upper 32 bits before doing anything
with the system call number, both on the slow and fast paths, if and
only if x32 was enabled.

Now we always mask out the upper 32 bits on the slow path, so it's not
quite consistent with the fast path if x32 is disabled.  A system call
that would be rejected by the fast path can succeed on the slow path.
I don't know whether this causes any problems, but it seems
undesirable.

But it's also undesirable that the behaviour of system call numbers not
assigned to x32 also varies depending on whether x32 is enabled.
Should we always mask out the upper 32 bits on the fast path?

Ben.

-- 
Ben Hutchings
In a hierarchy, every employee tends to rise to his level of incompetence.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

System call number masking Ben Hutchings <ben@decadent.org.uk> - 2016-04-14 19:30 +0200
  Re: System call number masking Andy Lutomirski <luto@amacapital.net> - 2016-04-14 19:50 +0200

csiph-web