Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1379089

Re: [PATCH v2 2/3] devicetree: leds: Introduce "panic-indicator" optional property

Show all headers | View raw

Hi Ezequiel,

On 13/04/16 19:08, Ezequiel Garcia wrote:
> It's desirable to specify which LEDs are to be blinked on a kernel
> panic. Therefore, introduce a devicetree boolean property to mark
> which LEDs should be treated this way, if possible.
>
> Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
> ---
>   Documentation/devicetree/bindings/leds/common.txt | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt
> index 68419843e32f..7b646a7808ce 100644
> --- a/Documentation/devicetree/bindings/leds/common.txt
> +++ b/Documentation/devicetree/bindings/leds/common.txt
> @@ -37,6 +37,9 @@ Optional properties for child nodes:
>                        property is mandatory for the LEDs in the non-flash modes
>                        (e.g. torch or indicator).
>
> +- panic-indicator : This properties specifies that the LED should be used,

s/properties/property/

Maybe phrasing it as "should also be used" might make the intention a 
bit clearer, as well.

Robin.

> +		    if at all possible, as a panic indicator.
> +
>   Required properties for flash LED child nodes:
>   - flash-max-microamp : Maximum flash LED supply current in microamperes.
>   - flash-max-timeout-us : Maximum timeout in microseconds after which the flash
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/3] Extend the LED panic trigger Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> - 2016-04-13 20:10 +0200
  [PATCH v2 3/3] leds: gpio: Support the "panic-indicator" firmware property Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> - 2016-04-13 20:10 +0200
    Re: [PATCH v2 3/3] leds: gpio: Support the "panic-indicator" firmware  property Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-04-14 11:00 +0200
  [PATCH v2 1/3] leds: triggers: Allow to switch the trigger to "panic" on a kernel panic Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> - 2016-04-13 20:10 +0200
  [PATCH v2 2/3] devicetree: leds: Introduce "panic-indicator" optional property Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> - 2016-04-13 20:10 +0200
    Re: [PATCH v2 2/3] devicetree: leds: Introduce "panic-indicator"  optional property Rob Herring <robh@kernel.org> - 2016-04-14 18:40 +0200
    Re: [PATCH v2 2/3] devicetree: leds: Introduce "panic-indicator"  optional property Robin Murphy <robin.murphy@arm.com> - 2016-04-14 18:50 +0200

csiph-web