Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1379065
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/2] dt/bindings/spi: Add bindings for PIC32 Quad-SPI driver. |
| Date | 2016-04-14 18:20 +0200 |
| Message-ID | <rnS9Q-4Iu-13@gated-at.bofh.it> (permalink) |
| References | <rnsS5-1JU-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Apr 13, 2016 at 06:42:04PM +0530, Purna Chandra Mandal wrote:
> Document Device tree bindings for quad SPI peripheral
> found on Microchip PIC32 class devices.
>
> Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com>
>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Brown <broonie@kernel.org>
> ---
>
> Documentation/devicetree/bindings/spi/sqi-pic32.txt | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/spi/sqi-pic32.txt
One nit below, otherwise:
Acked-by: Rob Herring <rob@kernel.org>
>
> diff --git a/Documentation/devicetree/bindings/spi/sqi-pic32.txt b/Documentation/devicetree/bindings/spi/sqi-pic32.txt
> new file mode 100644
> index 0000000..5af9fab
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/sqi-pic32.txt
> @@ -0,0 +1,18 @@
> +Microchip PIC32 Quad SPI controller
> +-----------------------------------
> +Required properties:
> +- compatible: Should be "microchip,pic32mzda-sqi".
> +- reg: Address and length of SQI controller register space.
> +- interrupts: Should contain SQI interrupt.
> +- clocks: Should contain phandle of two clocks in sequence, clock that drives
> + clock on SPI bus and clock that drives SQI controller.
> +- clock-names: Should be "spi_ck" and "reg_ck" in order.
> +
> +Example:
> + sqi1: sqi@1f8e2000 {
spi@...
> + compatible = "microchip,pic32mzda-sqi";
> + reg = <0x1f8e2000 0x200>;
> + clocks = <&rootclk REF2CLK>, <&rootclk PB5CLK>;
> + clock-names = "spi_ck", "reg_ck";
> + interrupts = <169 IRQ_TYPE_LEVEL_HIGH>;
> + };
> --
> 1.8.3.1
>
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH 1/2] dt/bindings/spi: Add bindings for PIC32 Quad-SPI driver. Purna Chandra Mandal <purna.mandal@microchip.com> - 2016-04-13 15:20 +0200 Re: [PATCH 1/2] dt/bindings/spi: Add bindings for PIC32 Quad-SPI driver. Mark Brown <broonie@kernel.org> - 2016-04-13 15:20 +0200 [PATCH 2/2] spi: pic32-sqi: add SPI driver for PIC32 SQI controller. Purna Chandra Mandal <purna.mandal@microchip.com> - 2016-04-13 15:20 +0200 Re: [PATCH 1/2] dt/bindings/spi: Add bindings for PIC32 Quad-SPI driver. Rob Herring <robh@kernel.org> - 2016-04-14 18:20 +0200
csiph-web