[PATCH 1/2] staging: wilc1000: fix double unlock

From	Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH 1/2] staging: wilc1000: fix double unlock
Date	2016-04-14 17:30 +0200
Message-ID	<rnRns-3WP-15@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

The semaphore was being released twice, once at the beginning of the
thread and then again when the thread is about to close.
The semaphore is acquired immediately after creating the thread so we
should be releasing it when the thread ends.

Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
---
 drivers/staging/wilc1000/linux_wlan.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c
index a858552..5643a3d 100644
--- a/drivers/staging/wilc1000/linux_wlan.c
+++ b/drivers/staging/wilc1000/linux_wlan.c
@@ -313,7 +313,6 @@ static int linux_wlan_txq_task(void *vp)
 	vif = netdev_priv(dev);
 	wl = vif->wilc;
 
-	up(&wl->txq_thread_started);
 	while (1) {
 		down(&wl->txq_event);
 
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] staging: wilc1000: fix double unlock Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-04-14 17:30 +0200
  [PATCH 2/2] staging: wilc1000: remove unused variables Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-04-14 17:30 +0200

csiph-web