Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1379055

Re: [PATCH 0/3] v4.4: Revert "PCI: Implement pcibios_alloc_irq() and

Show all headers | View raw

Hi Bjorn,

On Wed, Apr 13, 2016 at 12:56:59AM -0500, Bjorn Helgaas wrote:
> We reverted the following changes from v4.5 to fix a regression:
> 
>   8affb487d4a4 ("x86/PCI: Don't alloc pcibios-irq when MSI is enabled")
>   811a4e6fce09 ("PCI: Add helpers to manage pci_dev->irq and pci_dev->irq_managed")
>   991de2e59090 ("PCI, x86: Implement pcibios_alloc_irq() and pcibios_free_irq()")

Do you have a link to the thread about these issues? I'd like to have a
look at what has been tried to solve the regressions before the revert.

I had a look at commit 991de2e59090 and noted that the main difference
it introduces is that the pcibios-irq is allocated earlier (probe time,
before the commit it was pci_enable_device() time). In fact, it is now
allocated before pci_enable_resources() has been called on the device
(as far as I can see). I wonder if the regression can be fixed by
also moving pci_enable_resources() to probe time.


Regards,

	Joerg

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] v4.4: Revert "PCI: Implement pcibios_alloc_irq() and Bjorn Helgaas <bhelgaas@google.com> - 2016-04-13 08:00 +0200
  [PATCH 3/3] Revert "PCI,  x86: Implement pcibios_alloc_irq() and pcibios_free_irq()" Bjorn Helgaas <bhelgaas@google.com> - 2016-04-13 08:00 +0200
  [PATCH 1/3] Revert "x86/PCI: Don't alloc pcibios-irq when MSI is  enabled" Bjorn Helgaas <bhelgaas@google.com> - 2016-04-13 08:00 +0200
  [PATCH 2/3] Revert "PCI: Add helpers to manage pci_dev->irq and  pci_dev->irq_managed" Bjorn Helgaas <bhelgaas@google.com> - 2016-04-13 08:00 +0200
  Re: [PATCH 0/3] v4.4: Revert "PCI: Implement pcibios_alloc_irq() and Joerg Roedel <jroedel@suse.de> - 2016-04-14 18:00 +0200
    Re: [PATCH 0/3] v4.4: Revert "PCI: Implement pcibios_alloc_irq() and Bjorn Helgaas <helgaas@kernel.org> - 2016-04-15 17:10 +0200

csiph-web