Re: [PATCH] qlge: Replace create_singlethread_workqueue with alloc_ordered_workqueue

From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] qlge: Replace create_singlethread_workqueue with alloc_ordered_workqueue
Date	2016-04-14 17:50 +0200
Message-ID	<rnRGO-44y-19@gated-at.bofh.it> (permalink)
References	<rlZIt-4lP-1@gated-at.bofh.it> <rnx5o-4TK-15@gated-at.bofh.it> <rnLi3-7rI-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello, Manish.

On Thu, Apr 14, 2016 at 07:25:15AM +0000, Manish Chopra wrote:
> Just want to confirm that __WQ_LEGACY flag is not necessary here as this is removed
> with this change ? 

Yeah, that should be fine.  That only affects locking dependency
tracking which can fire spuriously due to workqueues created with the
old interface having WQ_MEM_RECLAIM unconditionally.  In this case, we
actually want WQ_MEM_RECLAIM and thus we want the dependency tracking
too.

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] qlge: Replace create_singlethread_workqueue with  alloc_ordered_workqueue Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-04-09 14:00 +0200
  Re: [PATCH] qlge: Replace create_singlethread_workqueue with  alloc_ordered_workqueue Tejun Heo <tj@kernel.org> - 2016-04-13 19:50 +0200
    RE: [PATCH] qlge: Replace create_singlethread_workqueue with  alloc_ordered_workqueue Manish Chopra <manish.chopra@qlogic.com> - 2016-04-14 11:00 +0200
      Re: [PATCH] qlge: Replace create_singlethread_workqueue with  alloc_ordered_workqueue Tejun Heo <tj@kernel.org> - 2016-04-14 17:50 +0200

csiph-web