Re: [PATCH 3/4] dt-bindings: Update iProc GPIO bindings

From	Rob Herring <robh@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/4] dt-bindings: Update iProc GPIO bindings
Date	2016-04-14 16:40 +0200
Message-ID	<rnQB4-33W-9@gated-at.bofh.it> (permalink)
References	<rngHg-8eN-7@gated-at.bofh.it> <rngQW-8jN-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Apr 12, 2016 at 05:15:22PM -0700, Ray Jui wrote:
> Update the iProc GPIO binding document to introduce a new compatible
> string "brcm,iproc-gpio-only", that allows the generic pinconf function
> to be disabled completely
> 
> Signed-off-by: Ray Jui <ray.jui@broadcom.com>
> Reviewed-by: Jon Mason <jon.mason@broadcom.com>
> Reviewed-by: Scott Branden <scott.branden@broadcom.com>
> ---
>  Documentation/devicetree/bindings/pinctrl/brcm,iproc-gpio.txt | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/brcm,iproc-gpio.txt b/Documentation/devicetree/bindings/pinctrl/brcm,iproc-gpio.txt
> index ddaa1b0..75a4370 100644
> --- a/Documentation/devicetree/bindings/pinctrl/brcm,iproc-gpio.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/brcm,iproc-gpio.txt
> @@ -3,8 +3,11 @@ Broadcom iProc GPIO/PINCONF Controller
>  Required properties:
>  
>  - compatible:
> -    Must be "brcm,cygnus-ccm-gpio", "brcm,cygnus-asiu-gpio",
> -    "brcm,cygnus-crmu-gpio" or "brcm,iproc-gpio"
> +    For Cygnus, it must be brcm,cygnus-ccm-gpio", "brcm,cygnus-asiu-gpio", or
> +"brcm,cygnus-crmu-gpio"
> +    For non-Cygnus iProc SoCs, it must be either "brcm,iproc-gpio-only" (if
> +only GPIO is supported) or "brcm,iproc-gpio" (if both generic pinconf and GPIO
> +are supported)

No. That's not how compatible strings work. Use SoC specific compatible 
strings if you need to distinguish this.

Rob

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] Additional iProc GPIO support Ray Jui <ray.jui@broadcom.com> - 2016-04-13 02:30 +0200
  [PATCH 3/4] dt-bindings: Update iProc GPIO bindings Ray Jui <ray.jui@broadcom.com> - 2016-04-13 02:30 +0200
    Re: [PATCH 3/4] dt-bindings: Update iProc GPIO bindings Rob Herring <robh@kernel.org> - 2016-04-14 16:40 +0200

csiph-web