Re: [PATCH v3 3/3] drm: bridge: anx78xx: Add anx78xx driver support.

From	Emil Velikov <emil.l.velikov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 3/3] drm: bridge: anx78xx: Add anx78xx driver support.
Date	2016-04-14 16:10 +0200
Message-ID	<rnQ81-2QW-5@gated-at.bofh.it> (permalink)
References	<rlEb0-3RN-25@gated-at.bofh.it> <rlEb0-3RN-23@gated-at.bofh.it> <rnPlE-2aV-5@gated-at.bofh.it> <rnPOH-2pl-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Enric,

On 14 April 2016 at 14:42, Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
> The patch was implemented first without OR'ing error codes. The reason why I
> changed this is because I received the comments that checking the error on
> every regmap_* didn't help the readability of the driver and is likely to
> not fail if the first call doesn't fail.
>
> For example, originally the code was like this:
>   http://pastebin.com/rPgyji8k
> but I changed to this
>   http://pastebin.com/rPgyji8k
>
Both links are the same ;-) But I believe we all get what you meant.

Just a side note: many other drivers in DRM subsystem, inconsistently
check the return value of the regmap API. Note sure how likely is any
of it [regmap_foo] to fail and/or how determined people are to handle
every possible error case.

-Emil

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/3] Add ANX7814 I2C bridge driver Enric Balletbo i Serra <enric.balletbo@collabora.com> - 2016-04-08 15:00 +0200
  [PATCH v3 2/3] devicetree: Add ANX7814 SlimPort transmitter binding. Enric Balletbo i Serra <enric.balletbo@collabora.com> - 2016-04-08 15:00 +0200
  Re: [PATCH v3 3/3] drm: bridge: anx78xx: Add anx78xx driver support. Thierry Reding <treding@nvidia.com> - 2016-04-14 15:20 +0200
    Re: [PATCH v3 3/3] drm: bridge: anx78xx: Add anx78xx driver support. Enric Balletbo i Serra <enric.balletbo@collabora.com> - 2016-04-14 15:50 +0200
      Re: [PATCH v3 3/3] drm: bridge: anx78xx: Add anx78xx driver support. Enric Balletbo i Serra <enric.balletbo@collabora.com> - 2016-04-14 16:10 +0200
        Re: [PATCH v3 3/3] drm: bridge: anx78xx: Add anx78xx driver support. Thierry Reding <treding@nvidia.com> - 2016-04-14 16:40 +0200
      Re: [PATCH v3 3/3] drm: bridge: anx78xx: Add anx78xx driver support. Emil Velikov <emil.l.velikov@gmail.com> - 2016-04-14 16:10 +0200

csiph-web