Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1378647

[patch] target/transport: Silence unitialized variable warnings

Show all headers | View raw

The core_scsi3_ua_for_check_condition() can return without initializing
these variables.  I have initialized them to zero so that it triggers a
WARN_ON_ONCE() in that situation.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
index ab2bf12..851e634 100644
--- a/drivers/target/target_core_transport.c
+++ b/drivers/target/target_core_transport.c
@@ -2884,7 +2884,8 @@ static int translate_sense_reason(struct se_cmd *cmd, sense_reason_t reason)
 	const struct sense_info *si;
 	u8 *buffer = cmd->sense_buffer;
 	int r = (__force int)reason;
-	u8 asc, ascq;
+	u8 asc = 0;
+	u8 ascq = 0;
 	bool desc_format = target_sense_desc_format(cmd->se_dev);
 
 	if (r < ARRAY_SIZE(sense_info_table) && sense_info_table[r].key)

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[patch] target/transport: Silence unitialized variable warnings Dan Carpenter <dan.carpenter@oracle.com> - 2016-04-14 11:40 +0200

csiph-web