Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1378604
| From | Suzuki K Poulose <Suzuki.Poulose@arm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] sunxi-irq: Fix Kconfig dependency on GENERIC_IRQ_CHIP |
| Date | 2016-04-14 10:50 +0200 |
| Message-ID | <rnL8m-7nM-7@gated-at.bofh.it> (permalink) |
| References | <rnvmW-3u7-33@gated-at.bofh.it> <rnzgS-6Pc-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 13/04/16 21:07, Maxime Ripard wrote: > Hi, > > On Wed, Apr 13, 2016 at 04:59:27PM +0100, Suzuki K Poulose wrote: >> The sunxi-nmi and sun4i irq chips are selected by ARCH_SUNXI on both arm >> and arm64 (recently added). However on arm64, we don't explicitly select >> GENERIC_IRQ_CHIP which is required by the sunxi-nmi irq chip driver and >> causes build breaks on 4.6-rc1 : >> diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile >> index b03cfcb..c9626f4 100644 >> --- a/drivers/irqchip/Makefile >> +++ b/drivers/irqchip/Makefile >> @@ -19,8 +19,8 @@ obj-$(CONFIG_CLPS711X_IRQCHIP) += irq-clps711x.o >> obj-$(CONFIG_OR1K_PIC) += irq-or1k-pic.o >> obj-$(CONFIG_ORION_IRQCHIP) += irq-orion.o >> obj-$(CONFIG_OMAP_IRQCHIP) += irq-omap-intc.o >> -obj-$(CONFIG_ARCH_SUNXI) += irq-sun4i.o >> -obj-$(CONFIG_ARCH_SUNXI) += irq-sunxi-nmi.o >> +obj-$(CONFIG_SUNXI_IRQCHIP) += irq-sun4i.o >> +obj-$(CONFIG_SUNXI_IRQCHIP) += irq-sunxi-nmi.o > > Those are two different drivers, that should be selected by different > SoCs (MACH_SUN4I and MACH_SUN5I for the former, SUN6I, SUN7I and SUN8I > for the latter) OK. I had thought about that, but wasn't sure who needs what. So went with what existed already. I can respin it. Cheers Suzuki
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2] sunxi-irq: Fix Kconfig dependency on GENERIC_IRQ_CHIP Suzuki K Poulose <suzuki.poulose@arm.com> - 2016-04-13 18:00 +0200
Re: [PATCH v2] sunxi-irq: Fix Kconfig dependency on GENERIC_IRQ_CHIP Marc Zyngier <marc.zyngier@arm.com> - 2016-04-13 18:20 +0200
Re: [PATCH v2] sunxi-irq: Fix Kconfig dependency on GENERIC_IRQ_CHIP Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-04-13 22:10 +0200
Re: [PATCH v2] sunxi-irq: Fix Kconfig dependency on GENERIC_IRQ_CHIP Suzuki K Poulose <Suzuki.Poulose@arm.com> - 2016-04-14 10:50 +0200
Re: [PATCH v2] sunxi-irq: Fix Kconfig dependency on GENERIC_IRQ_CHIP Suzuki K Poulose <Suzuki.Poulose@arm.com> - 2016-04-14 11:00 +0200
Re: [PATCH v2] sunxi-irq: Fix Kconfig dependency on GENERIC_IRQ_CHIP Andre Przywara <andre.przywara@arm.com> - 2016-04-14 11:20 +0200
Re: [PATCH v2] sunxi-irq: Fix Kconfig dependency on GENERIC_IRQ_CHIP Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-04-14 19:20 +0200
csiph-web