Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1378581
| From | Jan Glauber <jan.glauber@caviumnetworks.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v6 06/19] i2c: octeon: Improve error status checking |
| Date | 2016-04-14 10:20 +0200 |
| Message-ID | <rnKFk-79W-21@gated-at.bofh.it> (permalink) |
| References | <rmLWN-81T-3@gated-at.bofh.it> <rmLWP-81T-31@gated-at.bofh.it> <rnoOu-714-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Apr 13, 2016 at 10:55:20AM +0200, Wolfram Sang wrote: > > Please have a look at Documentation/i2c/fault-codes. -EAGAIN is only for > arbitration loss. > > > + /* ACK allowed on pre-terminal bytes only */ > > + case STAT_RXDATA_ACK: > > + if (!final_read) > > + return 0; > > + return -EAGAIN; > > + > > + /* NAK allowed on terminal byte only */ > > + case STAT_RXDATA_NAK: > > + if (final_read) > > + return 0; > > + return -EAGAIN; > > -EIO? Can this happen? It is the master who sends the NAK, so we are in > control of that. If it happens not in the final_read part then it is an error, so -EIO would be better suited. Also for the other error codes I will follow your suggestion. Should I resend the whole series or will you review the other patches before? Thanks, Jan > > + > > + /* Arbitration lost */ > > + case STAT_LOST_ARB_38: > > + case STAT_LOST_ARB_68: > > + case STAT_LOST_ARB_78: > > + case STAT_LOST_ARB_B0: > > + return -EAGAIN; > > OK. > > > + > > + /* Being addressed as slave, should back off & listen */ > > + case STAT_SLAVE_60: > > + case STAT_SLAVE_70: > > + case STAT_GENDATA_ACK: > > + case STAT_GENDATA_NAK: > > + return -EIO; > > -EOPNOTSUPP? > > > + > > + /* Core busy as slave */ > > + case STAT_SLAVE_80: > > + case STAT_SLAVE_88: > > + case STAT_SLAVE_A0: > > + case STAT_SLAVE_A8: > > + case STAT_SLAVE_LOST: > > + case STAT_SLAVE_NAK: > > + case STAT_SLAVE_ACK: > > + return -EIO; > > -EOPNOTSUPP? > > > + case STAT_TXDATA_NAK: > > -EIO? > > > + case STAT_TXADDR_NAK: > > + case STAT_RXADDR_NAK: > > + case STAT_AD2W_NAK: > > -ENXIO? > > > + return -EAGAIN; > > + default: > > + dev_err(i2c->dev, "unhandled state: %d\n", stat); > > + return -EIO; > > OK. >
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v6 00/19] i2c-octeon and i2c-thunderx drivers Jan Glauber <jglauber@cavium.com> - 2016-04-11 17:30 +0200
[PATCH v6 14/19] i2c: octeon: Move read function before write Jan Glauber <jglauber@cavium.com> - 2016-04-11 17:30 +0200
[PATCH v6 06/19] i2c: octeon: Improve error status checking Jan Glauber <jglauber@cavium.com> - 2016-04-11 17:30 +0200
Re: [PATCH v6 06/19] i2c: octeon: Improve error status checking Wolfram Sang <wsa@the-dreams.de> - 2016-04-13 11:00 +0200
Re: [PATCH v6 06/19] i2c: octeon: Improve error status checking Jan Glauber <jan.glauber@caviumnetworks.com> - 2016-04-14 10:20 +0200
Re: [PATCH v6 06/19] i2c: octeon: Improve error status checking Wolfram Sang <wsa@the-dreams.de> - 2016-04-14 11:10 +0200
[PATCH v6 10/19] i2c: octeon: Add support for cn78xx chips Jan Glauber <jglauber@cavium.com> - 2016-04-11 17:30 +0200
[PATCH v6 11/19] i2c: octeon: Flush TWSI writes with readback Jan Glauber <jglauber@cavium.com> - 2016-04-11 17:40 +0200
[PATCH v6 15/19] i2c: octeon: Rename driver to prepare for split Jan Glauber <jglauber@cavium.com> - 2016-04-11 17:40 +0200
[PATCH v6 17/19] i2c: thunderx: Add i2c driver for ThunderX SOC Jan Glauber <jglauber@cavium.com> - 2016-04-11 17:40 +0200
[PATCH v6 02/19] i2c: octeon: Move set-clock and init-lowlevel upward Jan Glauber <jglauber@cavium.com> - 2016-04-11 17:40 +0200
Re: [PATCH v6 02/19] i2c: octeon: Move set-clock and init-lowlevel upward Wolfram Sang <wsa@the-dreams.de> - 2016-04-13 10:50 +0200
[PATCH v6 19/19] i2c: thunderx: Add smbus alert support Jan Glauber <jglauber@cavium.com> - 2016-04-11 17:40 +0200
[PATCH v6 03/19] i2c: octeon: Rename [read|write]_sw to reg_[read|write] Jan Glauber <jglauber@cavium.com> - 2016-04-11 17:40 +0200
Re: [PATCH v6 03/19] i2c: octeon: Rename [read|write]_sw to reg_[read|write] Wolfram Sang <wsa@the-dreams.de> - 2016-04-13 10:50 +0200
Re: [PATCH v6 03/19] i2c: octeon: Rename [read|write]_sw to reg_[read|write] Jan Glauber <jan.glauber@caviumnetworks.com> - 2016-04-14 10:00 +0200
Re: [PATCH v6 03/19] i2c: octeon: Rename [read|write]_sw to reg_[read|write] Wolfram Sang <wsa@the-dreams.de> - 2016-04-14 11:00 +0200
[PATCH v6 13/19] i2c: octeon: Add workaround for broken irqs on CN3860 Jan Glauber <jglauber@cavium.com> - 2016-04-11 17:40 +0200
[PATCH v6 07/19] i2c: octeon: Use i2c recovery framework Jan Glauber <jglauber@cavium.com> - 2016-04-11 17:40 +0200
[PATCH v6 05/19] i2c: octeon: Remove superfluous check in octeon_i2c_test_iflg Jan Glauber <jglauber@cavium.com> - 2016-04-11 17:40 +0200
Re: [PATCH v6 05/19] i2c: octeon: Remove superfluous check in octeon_i2c_test_iflg Wolfram Sang <wsa@the-dreams.de> - 2016-04-14 11:00 +0200
[PATCH v6 04/19] i2c: octeon: Introduce helper functions for register access Jan Glauber <jglauber@cavium.com> - 2016-04-11 17:40 +0200
Re: [PATCH v6 04/19] i2c: octeon: Introduce helper functions for register access Wolfram Sang <wsa@the-dreams.de> - 2016-04-13 10:50 +0200
Re: [PATCH v6 04/19] i2c: octeon: Introduce helper functions for register access Jan Glauber <jan.glauber@caviumnetworks.com> - 2016-04-14 10:20 +0200
Re: [PATCH v6 04/19] i2c: octeon: Introduce helper functions for register access Wolfram Sang <wsa@the-dreams.de> - 2016-04-14 11:00 +0200
[PATCH v6 08/19] i2c: octeon: Enable High-Level Controller Jan Glauber <jglauber@cavium.com> - 2016-04-11 17:40 +0200
csiph-web