Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1378408

Re: [PATCH] net-next: mediatek: add support for IRQ grouping

Path csiph.com!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From David Miller <davem@davemloft.net>
Newsgroups linux.kernel
Subject Re: [PATCH] net-next: mediatek: add support for IRQ grouping
Date Thu, 14 Apr 2016 04:30:01 +0200
Message-ID <rnFcB-2RY-9@gated-at.bofh.it> (permalink)
References <rlmQO-82W-13@gated-at.bofh.it>
X-Mailer Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
MIME-Version 1.0
Content-Type Text/Plain; charset=us-ascii
Content-Transfer-Encoding 7bit
X-Greylist Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 13 Apr 2016 19:22:40 -0700 (PDT)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 14
Organization linux.* mail to news gateway
X-Original-Cc nbd@openwrt.org, matthias.bgg@gmail.com, netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
X-Original-Date Wed, 13 Apr 2016 22:22:38 -0400 (EDT)
X-Original-Message-ID <20160413.222238.1174020501502372148.davem@davemloft.net>
X-Original-References <1460053499-53659-1-git-send-email-blogic@openwrt.org>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1378408

Show key headers only | View raw


From: John Crispin <blogic@openwrt.org>
Date: Thu,  7 Apr 2016 20:24:59 +0200

> The ethernet core has 3 IRQs. Using the IRQ grouping registers we are able
> to separate TX and RX IRQs, which allows us to service them on separate
> cores. This patch splits the IRQ handler into 2 separate functions, one
> for TX and another for RX. The TX housekeeping is split out of the NAPI
> handler. Instead we use a tasklet to handle housekeeping.
> 
> Signed-off-by: John Crispin <blogic@openwrt.org>

Don't do this with tasklets.

Do your TX reclaim in a NAPI poll just like the RX side.

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] net-next: mediatek: add support for IRQ grouping John Crispin <blogic@openwrt.org> - 2016-04-07 20:30 +0200
  Re: [PATCH] net-next: mediatek: add support for IRQ grouping David Miller <davem@davemloft.net> - 2016-04-14 04:30 +0200

csiph-web