[PATCH 5/7] mmc: sdhci-pltfm: use devm_ioremap_resource()

Path	csiph.com!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Masahiro Yamada <yamada.masahiro@socionext.com>
Newsgroups	linux.kernel
Subject	[PATCH 5/7] mmc: sdhci-pltfm: use devm_ioremap_resource()
Date	Thu, 14 Apr 2016 04:30:01 +0200
Message-ID	<rnFcB-2RY-3@gated-at.bofh.it> (permalink)
References	<rnFcB-2RY-5@gated-at.bofh.it>
X-Original-To	linux-mmc@vger.kernel.org
Dkim-Filter	OpenDKIM Filter v2.10.3 conuserg-07.nifty.com u3E2Sr3g010961
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1460600938; bh=LDcoN7N/UIV3zi449QVMP0xFp09DUFgja0f3Es1WHiw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2S+Bthmu7npeq/5x6PGNBtVhpofAO4tSk3jYh8JoazLbBOXCiZui5ZSkvyuPxyueK LZNKiNGzANrl0D6kfvQtfBmMbYbsOKFKi59hkY828+DnyAVhmiFcirIRSvlbpD+CbI Ul2fsnMwqkwOwxS0VYIjbObbwnpOfq7hlNAJ1eRD9cKLwqb/TbN9z34FdUU93OiV12 yA/0wjVTDQS7JKtn8B5JR76XSxlkM5akVXL6ZjoS+TwAxrfj+hVwG1Ac+QNHQvuTt6 p2Dr2hLQsp8+LTy3iHngDIO093fT39SnvfpUynD70o74PvwB1tNdbAjtU/TtzO/ItH A7PDIOV3A9ung==
X-Nifty-Srcip	[153.142.97.92]
X-Mailer	git-send-email 1.9.1
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	40
Organization	linux.* mail to news gateway
X-Original-Cc	Masahiro Yamada <yamada.masahiro@socionext.com>, linux-kernel@vger.kernel.org, Adrian Hunter <adrian.hunter@intel.com>, Ulf Hansson <ulf.hansson@linaro.org>
X-Original-Date	Thu, 14 Apr 2016 11:29:48 +0900
X-Original-Message-ID	<1460600990-10993-6-git-send-email-yamada.masahiro@socionext.com>
X-Original-References	<1460600990-10993-1-git-send-email-yamada.masahiro@socionext.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1378406

Show key headers only | View raw

The chain of devm_request_mem_region() and devm_ioremap() can be
replaced with devm_ioremap_resource().  Also, we can drop the error
messages because devm_ioremap_resource() displays similar messages
on error.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 drivers/mmc/host/sdhci-pltfm.c | 16 +++-------------
 1 file changed, 3 insertions(+), 13 deletions(-)

diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c
index c81a72d..94955e1 100644
--- a/drivers/mmc/host/sdhci-pltfm.c
+++ b/drivers/mmc/host/sdhci-pltfm.c
@@ -158,19 +158,9 @@ struct sdhci_host *sdhci_pltfm_init(struct platform_device *pdev,
 		goto err_request;
 	}
 
-	if (!devm_request_mem_region(&pdev->dev, iomem->start,
-				     resource_size(iomem),
-				     mmc_hostname(host->mmc))) {
-		dev_err(&pdev->dev, "cannot request region\n");
-		ret = -EBUSY;
-		goto err_request;
-	}
-
-	host->ioaddr = devm_ioremap(&pdev->dev, iomem->start,
-				    resource_size(iomem));
-	if (!host->ioaddr) {
-		dev_err(&pdev->dev, "failed to remap registers\n");
-		ret = -ENOMEM;
+	host->ioaddr = devm_ioremap_resource(&pdev->dev, iomem);
+	if (IS_ERR(host->ioaddr)) {
+		ret = PTR_ERR(host->ioaddr);
 		goto err_request;
 	}
 
-- 
1.9.1

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 5/7] mmc: sdhci-pltfm: use devm_ioremap_resource() Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-04-14 04:30 +0200

csiph-web