Re: [PATCH v2 0/2] perf probe fixes for ppc64le

From	Balbir Singh <bsingharora@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 0/2] perf probe fixes for ppc64le
Date	2016-04-14 03:20 +0200
Message-ID	<rnE6S-1XS-1@gated-at.bofh.it> (permalink)
References	<rn2Ei-4JV-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 12/04/16 19:10, Naveen N. Rao wrote:
> This patchset fixes three issues found with perf probe on ppc64le:
> 1. 'perf test kallsyms' failure on ppc64le (reported by Michael
> Ellerman). This was due to the symbols being fixed up during symbol
> table load. This is fixed in patch 2 by delaying symbol fixup until
> later.
> 2. perf probe function offset was being calculated from the local entry
> point (LEP), which does not match user expectation when trying to look
> at function disassembly output (reported by Ananth N). This is fixed for
> kallsyms in patch 1 and for symbol table in patch 2.
> 3. perf probe failure with kretprobe when using kallsyms. This was
> failing as we were specifying an offset. This is fixed in patch 1.
> 
> A few examples demonstrating the issues and the fix:
> 

Given the choices, I think this makes sense

Acked-by: Balbir Singh <bsingharora@gmail.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/2] perf probe fixes for ppc64le "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2016-04-12 11:20 +0200
  [PATCH v2 2/2] perf tools: Fix kallsyms perf test on ppc64le "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2016-04-12 11:20 +0200
  Re: [PATCH v2 0/2] perf probe fixes for ppc64le Balbir Singh <bsingharora@gmail.com> - 2016-04-14 03:20 +0200

csiph-web