Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1376996

Re: [PATCH net v3] net: sched: do not requeue a NULL skb

From Eric Dumazet <eric.dumazet@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH net v3] net: sched: do not requeue a NULL skb
Date 2016-04-12 18:30 +0200
Message-ID <rn9mq-1RY-3@gated-at.bofh.it> (permalink)
References <rn0j7-2Nd-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, 2016-04-12 at 08:45 +0200, Lars Persson wrote:
> A failure in validate_xmit_skb_list() triggered an unconditional call
> to dev_requeue_skb with skb=NULL. This slowly grows the queue
> discipline's qlen count until all traffic through the queue stops.

> 
> Fixes: 55a93b3ea780 ("qdisc: validate skb without holding lock")
> Signed-off-by: Lars Persson <larper@axis.com>
> ---


Acked-by: Eric Dumazet <edumazet@google.com>

Thanks !

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH net v3] net: sched: do not requeue a NULL skb Lars Persson <lars.persson@axis.com> - 2016-04-12 08:50 +0200
  Re: [PATCH net v3] net: sched: do not requeue a NULL skb Eric Dumazet <eric.dumazet@gmail.com> - 2016-04-12 18:30 +0200
  Re: [PATCH net v3] net: sched: do not requeue a NULL skb David Miller <davem@davemloft.net> - 2016-04-14 07:30 +0200

csiph-web