Re: [PATCH] Axi-usb: Add support for 64-bit addressing.

From	Rob Herring <robh@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Axi-usb: Add support for 64-bit addressing.
Date	2016-04-12 16:10 +0200
Message-ID	<rn7aX-al-37@gated-at.bofh.it> (permalink)
References	<rmELE-2aR-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Apr 11, 2016 at 01:11:46PM +0530, Nava kishore Manne wrote:
> This patch updates the driver to support 64-bit DMA
> addressing.
> 
> Signed-off-by: Nava kishore Manne <navam@xilinx.com>
> ---
>  .../devicetree/bindings/usb/udc-xilinx.txt         |  3 +-
>  drivers/usb/gadget/udc/udc-xilinx.c                | 38 ++++++++++++++++++++--
>  2 files changed, 37 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/udc-xilinx.txt b/Documentation/devicetree/bindings/usb/udc-xilinx.txt
> index 47b4e39..d417872 100644
> --- a/Documentation/devicetree/bindings/usb/udc-xilinx.txt
> +++ b/Documentation/devicetree/bindings/usb/udc-xilinx.txt
> @@ -7,12 +7,13 @@ Required properties:
>  - interrupts		: Should contain single irq line of USB2 device
>  			  controller
>  - xlnx,has-builtin-dma	: if DMA is included
> -
> +- xlnx,addrwidth       : Should be the dma addressing size in bits(ex: 40 bits).

Now this property shows up in a 2nd device. Now I'm more convinced this 
is the wrong approach and should use dma-ranges.

Rob

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Axi-usb: Add support for 64-bit addressing. Nava kishore Manne <nava.manne@xilinx.com> - 2016-04-11 09:50 +0200
  Re: [PATCH] Axi-usb: Add support for 64-bit addressing. kbuild test robot <lkp@intel.com> - 2016-04-11 10:10 +0200
  Re: [PATCH] Axi-usb: Add support for 64-bit addressing. Rob Herring <robh@kernel.org> - 2016-04-12 16:10 +0200

csiph-web