Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1376771
| From | Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v4 2/2] usb: dwc3: add debugfs node to dump FIFO/Queue available space |
| Date | 2016-04-12 15:00 +0200 |
| Message-ID | <rn65c-7BQ-7@gated-at.bofh.it> (permalink) |
| References | <rn4G6-6Eg-7@gated-at.bofh.it> <rn4G6-6Eg-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hello.
On 4/12/2016 2:10 PM, changbin.du@intel.com wrote:
> From: "Du, Changbin" <changbin.du@intel.com>
>
> For DWC3 USB controller, the Global Debug Queue/FIFO Space Available
> Register(GDBGFIFOSPACE) can be used to dump FIFO/Queue available space.
Space needed before (.
> This can be used to check some special issues, like whether data is
> successfully copied from memory to fifo when a trb is blocked.
>
> Signed-off-by: Du, Changbin <changbin.du@intel.com>
> ---
> v4:
> Do not fail silently, but print error.
[...]
> diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c
> index 615d4dc..83e5bc1 100644
> --- a/drivers/usb/dwc3/debugfs.c
> +++ b/drivers/usb/dwc3/debugfs.c
[...]
> @@ -642,10 +681,15 @@ void dwc3_debugfs_init(struct dwc3 *dwc)
> dwc->regset->nregs = ARRAY_SIZE(dwc3_regs);
> dwc->regset->base = dwc->regs;
>
> +
Why?
> file = debugfs_create_regset32("regdump", S_IRUGO, root, dwc->regset);
> if (!file)
> dev_err(dwc->dev, "Can't create debugfs regdump\n");
>
> + file = debugfs_create_file("fifo", S_IRUGO, root, dwc, &dwc3_fifo_fops);
> + if (!file)
> + dev_err(dwc->dev, "Can't create debugfs fifo\n");
> +
> if (IS_ENABLED(CONFIG_USB_DWC3_DUAL_ROLE)) {
> file = debugfs_create_file("mode", S_IRUGO | S_IWUSR, root,
> dwc, &dwc3_mode_fops);
MBR, Sergei
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] usb: dwc3: add debugfs node to dump FIFO/Queue available space changbin.du@intel.com - 2016-04-06 10:40 +0200
Re: [PATCH] usb: dwc3: add debugfs node to dump FIFO/Queue available space Greg KH <gregkh@linuxfoundation.org> - 2016-04-06 11:30 +0200
RE: [PATCH] usb: dwc3: add debugfs node to dump FIFO/Queue available space "Du, Changbin" <changbin.du@intel.com> - 2016-04-06 13:40 +0200
RE: [PATCH] usb: dwc3: add debugfs node to dump FIFO/Queue available space Felipe Balbi <balbi@kernel.org> - 2016-04-06 14:30 +0200
[PATCH v2 0/3] Improvement, fix and new entry for dwc3 debugfs changbin.du@intel.com - 2016-04-06 18:00 +0200
[PATCH v2 3/3] usb: dwc3: add debugfs node to dump FIFO/Queue available space changbin.du@intel.com - 2016-04-06 18:00 +0200
Re: [PATCH v2 0/3] Improvement, fix and new entry for dwc3 debugfs Felipe Balbi <balbi@kernel.org> - 2016-04-07 07:10 +0200
RE: [PATCH v2 0/3] Improvement, fix and new entry for dwc3 debugfs "Du, Changbin" <changbin.du@intel.com> - 2016-04-07 07:30 +0200
RE: [PATCH v2 0/3] Improvement, fix and new entry for dwc3 debugfs Felipe Balbi <balbi@kernel.org> - 2016-04-07 07:30 +0200
[PATCH v3 0/2] Add a new debugfs entry to dump FIFO/Queue available space changbin.du@intel.com - 2016-04-08 11:50 +0200
[PATCH v3 1/2] usb: dwc3: make dwc3_debugfs_init return value be void changbin.du@intel.com - 2016-04-08 11:50 +0200
Re: [PATCH v3 1/2] usb: dwc3: make dwc3_debugfs_init return value be void Felipe Balbi <balbi@kernel.org> - 2016-04-11 10:20 +0200
RE: [PATCH v3 1/2] usb: dwc3: make dwc3_debugfs_init return value be void "Du, Changbin" <changbin.du@intel.com> - 2016-04-11 13:20 +0200
RE: [PATCH v3 1/2] usb: dwc3: make dwc3_debugfs_init return value be void Felipe Balbi <balbi@kernel.org> - 2016-04-11 13:30 +0200
[PATCH v4 0/2] Add a new debugfs entry to dump FIFO/Queue available space changbin.du@intel.com - 2016-04-12 13:30 +0200
[PATCH v4 2/2] usb: dwc3: add debugfs node to dump FIFO/Queue available space changbin.du@intel.com - 2016-04-12 13:30 +0200
Re: [PATCH v4 2/2] usb: dwc3: add debugfs node to dump FIFO/Queue available space Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-04-12 15:00 +0200
RE: [PATCH v4 2/2] usb: dwc3: add debugfs node to dump FIFO/Queue available space "Du, Changbin" <changbin.du@intel.com> - 2016-04-14 05:30 +0200
Re: [PATCH v4 2/2] usb: dwc3: add debugfs node to dump FIFO/Queue available space Felipe Balbi <balbi@kernel.org> - 2016-04-14 10:10 +0200
RE: [PATCH v4 2/2] usb: dwc3: add debugfs node to dump FIFO/Queue available space "Du, Changbin" <changbin.du@intel.com> - 2016-04-14 13:20 +0200
RE: [PATCH v4 2/2] usb: dwc3: add debugfs node to dump FIFO/Queue available space Felipe Balbi <balbi@kernel.org> - 2016-04-14 13:30 +0200
RE: [PATCH v4 2/2] usb: dwc3: add debugfs node to dump FIFO/Queue available space "Du, Changbin" <changbin.du@intel.com> - 2016-04-14 13:40 +0200
RE: [PATCH v4 2/2] usb: dwc3: add debugfs node to dump FIFO/Queue available space Felipe Balbi <balbi@kernel.org> - 2016-04-14 13:50 +0200
RE: [PATCH v4 2/2] usb: dwc3: add debugfs node to dump FIFO/Queue available space "Du, Changbin" <changbin.du@intel.com> - 2016-04-14 14:00 +0200
[PATCH v4 1/2] usb: dwc3: make dwc3_debugfs_init return value be void changbin.du@intel.com - 2016-04-12 13:30 +0200
[PATCH v3 2/2] usb: dwc3: add debugfs node to dump FIFO/Queue available space changbin.du@intel.com - 2016-04-08 11:50 +0200
csiph-web