Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1376709
| From | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v7 2/4] power: reset: add reboot mode driver |
| Date | 2016-04-12 13:20 +0200 |
| Message-ID | <rn4wp-6yV-5@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <rie3o-7aW-1@gated-at.bofh.it> <rif97-7UH-1@gated-at.bofh.it> <rkJZ8-3Wx-5@gated-at.bofh.it> <rkK8O-4jp-1@gated-at.bofh.it> <rn2NX-4Qf-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 04/12/2016 11:27 AM, Andy Yan wrote:
>>>>> +
>>>>> +static const struct of_device_id syscon_reboot_mode_of_match[] = {
>>>>> + { .compatible = "syscon-reboot-mode" },
>>>>> + {}
>>>>> +};
>>>>> +
>>>>> +static struct platform_driver syscon_reboot_mode_driver = {
>>>>> + .probe = syscon_reboot_mode_probe,
>>>> Cleanup needed. What will happen after device unbind? Memory will be
>>>> released (devm-*()) but reboot notifier won't thus leading to OOPS on
>>>> reboot.
>>> From the kernel_restart_prepare function, the reboot notifier will
>>> be called before device_shutdown. Is there any other case the device
>>> unbind before reboot notifier
>>> called?
>> This is a regular module platform driver so unbind can happen any time
>> initiated by user, either by unbind command or by module removal. User
>> can then re-bind device or not - probably does not matter. Anyway after
>> such first unbind, the restart will kaboom instead of do a restart.
>
> I just need to do clean up in remove?
Yes, you need to clean up everything in remove() callback (in a reversed
order).
Best regards,
Krzysztof
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v7 2/4] power: reset: add reboot mode driver Andy Yan <andy.yan@rock-chips.com> - 2016-04-06 03:00 +0200
Re: [PATCH v7 2/4] power: reset: add reboot mode driver Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-06 03:10 +0200
Re: [PATCH v7 2/4] power: reset: add reboot mode driver Andy Yan <andy.yan@rock-chips.com> - 2016-04-12 11:30 +0200
Re: [PATCH v7 2/4] power: reset: add reboot mode driver Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-12 13:20 +0200
Re: [PATCH v7 2/4] power: reset: add reboot mode driver Andy Yan <andy.yan@rock-chips.com> - 2016-04-12 13:40 +0200
csiph-web