Re: [PATCH v6 07/10] usb: dwc3: gadget: Fix suspend/resume during dual-role mode

From	Felipe Balbi <balbi@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 07/10] usb: dwc3: gadget: Fix suspend/resume during dual-role mode
Date	2016-04-12 10:10 +0200
Message-ID	<rn1yy-3Sy-13@gated-at.bofh.it> (permalink)
References	(1 earlier) <rmIme-57L-23@gated-at.bofh.it> <rmJ8C-5Ts-7@gated-at.bofh.it> <rmJUZ-6uN-1@gated-at.bofh.it> <rmK4H-6zt-33@gated-at.bofh.it> <rmKxN-6PH-97@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

Roger Quadros <rogerq@ti.com> writes:
> On 11/04/16 16:26, Felipe Balbi wrote:
>> 
>> Hi,
>> 
>> Roger Quadros <rogerq@ti.com> writes:
>>> On 11/04/16 15:23, Felipe Balbi wrote:
>>>>
>>>> Hi,
>>>>
>>>> Roger Quadros <rogerq@ti.com> writes:
>>>>> Gadget controller might not be always active during suspend/
>>>>> resume when we are operating in dual-role/otg mode.
>>>>> Check if we're active and only if we are then perform
>>>>> necessary actions during suspend/resume.
>>>>
>>>> I don't get this. If we're operating in OTG, we should have a gadget
>>>> driver loaded, no ?
>>>>
>>> At boot gadget driver is not automatically loaded. We're still in OTG mode
>>> but OTG state machine hasn't started.
>>> System suspend/resume can still happen.
>>>
>>> User might also load/unload the gadget driver prior to system suspend.
>> 
>> good point, this should go in the -rc too.
>> 
> But there is no dual-role mode currently so it won't fix any bug yet :).

this should be a problem even for device-only, right ?

i) boot-up
ii) modprobe dwc3
iii) echo mem > /sys/power/state

-- 
balbi

Thread

[PATCH v6 07/10] usb: dwc3: gadget: Fix suspend/resume during dual-role mode Roger Quadros <rogerq@ti.com> - 2016-04-11 13:40 +0200
  Re: [PATCH v6 07/10] usb: dwc3: gadget: Fix suspend/resume during dual-role mode Felipe Balbi <balbi@kernel.org> - 2016-04-11 14:30 +0200
    Re: [PATCH v6 07/10] usb: dwc3: gadget: Fix suspend/resume during  dual-role mode Roger Quadros <rogerq@ti.com> - 2016-04-11 15:20 +0200
      Re: [PATCH v6 07/10] usb: dwc3: gadget: Fix suspend/resume during dual-role mode Felipe Balbi <balbi@kernel.org> - 2016-04-11 15:30 +0200
        Re: [PATCH v6 07/10] usb: dwc3: gadget: Fix suspend/resume during  dual-role mode Roger Quadros <rogerq@ti.com> - 2016-04-11 16:00 +0200
          Re: [PATCH v6 07/10] usb: dwc3: gadget: Fix suspend/resume during dual-role mode Felipe Balbi <balbi@kernel.org> - 2016-04-12 10:10 +0200
            Re: [PATCH v6 07/10] usb: dwc3: gadget: Fix suspend/resume during  dual-role mode Roger Quadros <rogerq@ti.com> - 2016-04-12 10:30 +0200

csiph-web