Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1374709

RE: [PATCH v2] gpio: pca953x: add PCAL9535 interrupt support for Galileo Gen2

Show all headers | View raw

Thanks Linus. I think the below patch(in fixes branch) should be merged into devel branch too, since the below patch is depended by this one in devel branch.

commit 9b8e3ec34318663affced3c14d960e78d760dd9a
Author: Yong Li <sdliyong@gmail.com>
Date:   Wed Mar 30 14:49:14 2016 +0800

    gpio: pca953x: Use correct u16 value for register word write

    The current implementation only uses the first byte in val,
    the second byte is always 0. Change it to use cpu_to_le16
    to write the two bytes into the register

    Cc: stable@vger.kernel.org
    Signed-off-by: Yong Li <sdliyong@gmail.com>
    Reviewed-by: Phil Reid <preid@electromag.com.au>
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Yong
> -----Original Message-----
> From: Linus Walleij [mailto:linus.walleij@linaro.org]
> Sent: Friday, April 08, 2016 21:21
> To: Li, Yong B <yong.b.li@intel.com>
> Cc: linux-gpio@vger.kernel.org; linux-kernel@vger.kernel.org; Alexandre
> Courbot <gnurou@gmail.com>; Andy Shevchenko
> <andriy.shevchenko@linux.intel.com>; Puustinen, Ismo
> <ismo.puustinen@intel.com>; Phil Reid <preid@electromag.com.au>
> Subject: Re: [PATCH v2] gpio: pca953x: add PCAL9535 interrupt support for
> Galileo Gen2
> 
> n Thu, Apr 7, 2016 at 6:56 AM, Yong Li <yong.b.li@intel.com> wrote:
> 
> > Galileo Gen2 board uses the PCAL9535 as the GPIO expansion, it is
> > different from PCA9535 and includes interrupt mask/status registers,
> > The current driver does not support the interrupt registers
> > configuration, it causes some gpio pins cannot trigger interrupt
> > events, this patch fix this issue. The original patch was submitted by
> > Josef Ahmad <josef.ahmad@linux.intel.com>
> > http://git.yoctoproject.org/cgit/cgit.cgi/meta-intel-quark/tree/recipe
> > s-kernel/linux/files/0015-Quark-GPIO-1-2-quark.patch
> >
> > Signed-off-by: Yong Li <yong.b.li@intel.com>
> 
> Patch applied with Andy's review tag.
> 
> Yours,
> Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] gpio: pca953x: add PCAL9535 interrupt support for Galileo Gen2 Yong Li <yong.b.li@intel.com> - 2016-04-07 07:10 +0200
  Re: [PATCH v2] gpio: pca953x: add PCAL9535 interrupt support for  Galileo Gen2 Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-04-07 13:10 +0200
  Re: [PATCH v2] gpio: pca953x: add PCAL9535 interrupt support for  Galileo Gen2 Linus Walleij <linus.walleij@linaro.org> - 2016-04-08 15:30 +0200
    RE: [PATCH v2] gpio: pca953x: add PCAL9535 interrupt support for  Galileo Gen2 "Li, Yong B" <yong.b.li@intel.com> - 2016-04-10 05:10 +0200
      Re: [PATCH v2] gpio: pca953x: add PCAL9535 interrupt support for  Galileo Gen2 Linus Walleij <linus.walleij@linaro.org> - 2016-04-14 14:10 +0200

csiph-web