Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1376308

Re: [RFC PATCH 02/12] PKCS#7: Make trust determination dependent on contents of trust keyring [ver #4]

From Mat Martineau <mathew.j.martineau@linux.intel.com>
Newsgroups linux.kernel
Subject Re: [RFC PATCH 02/12] PKCS#7: Make trust determination dependent on contents of trust keyring [ver #4]
Date 2016-04-12 00:30 +0200
Message-ID <rmSvg-4NV-33@gated-at.bofh.it> (permalink)
References <rldXc-1d9-3@gated-at.bofh.it> <rldXe-1d9-35@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, 7 Apr 2016, David Howells wrote:

> diff --git a/crypto/asymmetric_keys/pkcs7_trust.c b/crypto/asymmetric_keys/pkcs7_trust.c
> index b9a5487cd82d..0dccb6fe7634 100644
> --- a/crypto/asymmetric_keys/pkcs7_trust.c
> +++ b/crypto/asymmetric_keys/pkcs7_trust.c
> @@ -170,8 +162,7 @@ verified:
>  * May also return -ENOMEM.
>  */
> int pkcs7_validate_trust(struct pkcs7_message *pkcs7,
> -			 struct key *trust_keyring,
> -			 bool *_trusted)

This doesn't build after the keys-trust branch was rebased on v4.6-rc2. A 
reference to _trusted was added in commit e5435891 ("PKCS#7: 
pkcs7_validate_trust(): initialize the _trusted output argument"), right 
after the local declarations.

> +			 struct key *trust_keyring)
> {
> 	struct pkcs7_signed_info *sinfo;
> 	struct x509_certificate *p;

Regards,

--
Mat Martineau
Intel OTC

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[RFC PATCH 00/12] KEYS: Restrict additions to 'trusted' keyrings  [ver #4] David Howells <dhowells@redhat.com> - 2016-04-07 11:00 +0200
  [RFC PATCH 02/12] PKCS#7: Make trust determination dependent on  contents of trust keyring [ver #4] David Howells <dhowells@redhat.com> - 2016-04-07 11:00 +0200
    Re: [RFC PATCH 02/12] PKCS#7: Make trust determination dependent on  contents of trust keyring [ver #4] Mat Martineau <mathew.j.martineau@linux.intel.com> - 2016-04-12 00:30 +0200
      Re: [RFC PATCH 02/12] PKCS#7: Make trust determination dependent on contents of trust keyring [ver #4] David Howells <dhowells@redhat.com> - 2016-04-12 01:50 +0200
  [RFC PATCH 05/12] KEYS: Generalise x509_request_asymmetric_key()  [ver #4] David Howells <dhowells@redhat.com> - 2016-04-07 11:00 +0200
  [RFC PATCH 03/12] KEYS: Add a facility to restrict new links into a  keyring [ver #4] David Howells <dhowells@redhat.com> - 2016-04-07 11:10 +0200
  [RFC PATCH 08/12] KEYS: Make the system trusted keyring depend on  the asymmetric key type [ver #4] David Howells <dhowells@redhat.com> - 2016-04-07 11:10 +0200
  [RFC PATCH 01/12] KEYS: Generalise system_verify_data() to provide  access to internal content [ver #4] David Howells <dhowells@redhat.com> - 2016-04-07 11:10 +0200
  [RFC PATCH 10/12] KEYS: Remove KEY_FLAG_TRUSTED and  KEY_ALLOC_TRUSTED [ver #4] David Howells <dhowells@redhat.com> - 2016-04-07 11:10 +0200

csiph-web