Re: [PATCH v3] extcon: usb-gpio: Don't miss event during suspend/resume

From	Chanwoo Choi <cw00.choi@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] extcon: usb-gpio: Don't miss event during suspend/resume
Date	2016-04-12 00:50 +0200
Message-ID	<rmSOC-4W8-17@gated-at.bofh.it> (permalink)
References	<rkWjE-52m-23@gated-at.bofh.it> <rlzbk-np-15@gated-at.bofh.it> <rmKHq-7ch-75@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Roger,

On 2016년 04월 11일 23:04, Roger Quadros wrote:
> Pin state might have changed during suspend/resume while
> our interrupts were disabled and if device doesn't support wakeup.
> 
> Scan for change during resume for such case.
> 
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
> v3:
> - use queue_delayed_work() instead of directly calling usb_extcon_detect_cable()
> 
> v2:
> - only check for state change during resume if device wakeup is 
> 
>  drivers/extcon/extcon-usb-gpio.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c
> index bc61d11..bad2159 100644
> --- a/drivers/extcon/extcon-usb-gpio.c
> +++ b/drivers/extcon/extcon-usb-gpio.c
> @@ -185,6 +185,9 @@ static int usb_extcon_resume(struct device *dev)
>  	int ret = 0;
>  
>  	enable_irq(info->id_irq);
> +	if (!device_may_wakeup(dev))
> +		queue_delayed_work(system_power_efficient_wq,
> +				   &info->wq_detcable, 0);
>  
>  	return ret;
>  }
> 

Applied it.

Thanks,
Chanwoo Choi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] extcon: usb-gpio: Don't miss event during suspend/resume Roger Quadros <rogerq@ti.com> - 2016-04-06 16:10 +0200
  Re: [PATCH] extcon: usb-gpio: Don't miss event during suspend/resume Chanwoo Choi <cw00.choi@samsung.com> - 2016-04-08 01:40 +0200
  [PATCH v2] extcon: usb-gpio: Don't miss event during suspend/resume Roger Quadros <rogerq@ti.com> - 2016-04-08 09:40 +0200
    Re: [PATCH v2] extcon: usb-gpio: Don't miss event during suspend/resume Chanwoo Choi <cw00.choi@samsung.com> - 2016-04-11 02:40 +0200
      Re: [PATCH v2] extcon: usb-gpio: Don't miss event during  suspend/resume Grygorii Strashko <grygorii.strashko@ti.com> - 2016-04-11 10:40 +0200
        Re: [PATCH v2] extcon: usb-gpio: Don't miss event during suspend/resume Chanwoo Choi <cw00.choi@samsung.com> - 2016-04-11 13:20 +0200
          Re: [PATCH v2] extcon: usb-gpio: Don't miss event during  suspend/resume Roger Quadros <rogerq@ti.com> - 2016-04-11 13:40 +0200
            Re: [PATCH v2] extcon: usb-gpio: Don't miss event during suspend/resume Chanwoo Choi <cwchoi00@gmail.com> - 2016-04-11 15:20 +0200
              Re: [PATCH v2] extcon: usb-gpio: Don't miss event during  suspend/resume Roger Quadros <rogerq@ti.com> - 2016-04-11 16:10 +0200
    [PATCH v3] extcon: usb-gpio: Don't miss event during suspend/resume Roger Quadros <rogerq@ti.com> - 2016-04-11 16:10 +0200
      Re: [PATCH v3] extcon: usb-gpio: Don't miss event during suspend/resume Chanwoo Choi <cw00.choi@samsung.com> - 2016-04-12 00:50 +0200

csiph-web