Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1375897
| From | Oded Gabbay <oded.gabbay@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFT v2] iommu/amd: use subsys_initcall() on amdv2 iommu |
| Date | 2016-04-11 15:50 +0200 |
| Message-ID | <rmKo1-6L0-1@gated-at.bofh.it> (permalink) |
| References | <rdnh0-3tX-9@gated-at.bofh.it> <ri5Wa-18l-3@gated-at.bofh.it> <rlOWL-4YX-17@gated-at.bofh.it> <rmKo1-6L0-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Apr 11, 2016 at 4:28 PM, Christian König
<christian.koenig@amd.com> wrote:
>
> Am 09.04.2016 um 02:25 schrieb Luis R. Rodriguez:
>>
>> On Tue, Mar 29, 2016 at 10:41 AM, Luis R. Rodriguez <mcgrof@kernel.org> wrote:
>>>
>>> We need to ensure amd iommu v2 initializes before
>>> driver uses such as drivers/gpu/drm/amd/amdkfd/kfd_module.c,
>>> to do this make its init routine a subsys_initcall() which
>>> ensures its load init is called first than modules when
>>> built-in.
>>>
>>> This reverts the old work around implemented through commit
>>> 1bacc894c227fad8a7 ("drivers: Move iommu/ before gpu/ in Makefile"),
>>> instead of making the dependency implicit by linker order this
>>> makes the ordering requirement explicit through proper kernel
>>> APIs.
>>>
>>> Cc: Oded Gabbay <oded.gabbay@amd.com>
>>> Cc: Christian König <christian.koenig@amd.com>
>>> Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
>
>
> Sorry for not responding earlier. Just coming back to all the stuff on my TODO list.
>
> Patch is Acked-by: Christian König <christian.koenig@amd.com>
Christian,
Just wanted to be sure if you tested this patch-set or not.
I don't think it should be merged without testing. If you already
tested it than fine. If not, I think I can do it in the next week or
so (just came back from PTO).
Oded
>
>
> Regards,
> Christian.
>
>> *poke*
>>
>> Luis
>
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [RFT v2] iommu/amd: use subsys_initcall() on amdv2 iommu "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-04-09 02:30 +0200
Re: [RFT v2] iommu/amd: use subsys_initcall() on amdv2 iommu Oded Gabbay <oded.gabbay@gmail.com> - 2016-04-11 15:50 +0200
Re: [RFT v2] iommu/amd: use subsys_initcall() on amdv2 iommu "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-04-13 00:10 +0200
csiph-web