Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1375990

Re: [PATCH v2] ALSA: hda/realtek - Enable the ALC292 dock fixup on the Thinkpad T460s

Show all headers | View raw

On Mon, 11 Apr 2016 11:21:38 +0200,
Sven Eckelmann wrote:
> 
> The Lenovo Thinkpad T460s requires the alc_fixup_tpt440_dock as well in
> order to get working sound output on the docking stations headphone jack.
> 
> Patch tested on a Thinkpad T460s (20F9CT01WW) using a ThinkPad Ultradock
> on kernel 4.4.6.
> 
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> Tested-by: Simon Wunderlich <sw@simonwunderlich.de>
> ---
> v2:
>  - rebased on current master
> 
>  sound/pci/hda/patch_realtek.c | 18 +++++++++++++++++-
>  1 file changed, 17 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index fefe83f..36d371c 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -4760,6 +4760,8 @@ enum {
>  	ALC225_FIXUP_DELL1_MIC_NO_PRESENCE,
>  	ALC280_FIXUP_HP_HEADSET_MIC,
>  	ALC221_FIXUP_HP_FRONT_MIC,
> +	ALC292_FIXUP_TPT460_DOCK,
> +	ALC292_FIXUP_TPT460,
>  };
>  
>  static const struct hda_fixup alc269_fixups[] = {
> @@ -5409,6 +5411,18 @@ static const struct hda_fixup alc269_fixups[] = {
>  			{ }
>  		},
>  	},
> +	[ALC292_FIXUP_TPT460_DOCK] = {
> +		.type = HDA_FIXUP_FUNC,
> +		.v.func = alc_fixup_tpt440_dock,
> +		.chained = true,
> +		.chain_id = ALC269_FIXUP_THINKPAD_ACPI
> +	},
> +	[ALC292_FIXUP_TPT460] = {
> +		.type = HDA_FIXUP_FUNC,
> +		.v.func = alc_fixup_disable_aamix,
> +		.chained = true,
> +		.chain_id = ALC292_FIXUP_TPT460_DOCK,
> +	},

We don't need to add two entries but just one, something like below.

	[ALC292_FIXUP_TPT460] = {
		.type = HDA_FIXUP_FUNC,
		.v.func = alc_fixup_tpt440_dock,
		.chained = true,
		.chain_id = ALC293_FIXUP_LENOVO_SPK_NOISE,
	},

Does it work for you?


thanks,

Takashi

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] ALSA: hda/realtek - Enable the ALC292 dock fixup on the Thinkpad T460s Sven Eckelmann <sven@narfation.org> - 2016-04-11 11:30 +0200
  Re: [PATCH v2] ALSA: hda/realtek - Enable the ALC292 dock fixup on the Thinkpad T460s Takashi Iwai <tiwai@suse.de> - 2016-04-11 16:10 +0200
    Re: [PATCH v2] ALSA: hda/realtek - Enable the ALC292 dock fixup on the Thinkpad T460s Sven Eckelmann <sven@narfation.org> - 2016-04-11 16:50 +0200
      Re: [PATCH v2] ALSA: hda/realtek - Enable the ALC292 dock fixup on the Thinkpad T460s Takashi Iwai <tiwai@suse.de> - 2016-04-11 16:50 +0200

csiph-web