Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1375977

Re: [PATCH v5 6/9] irqchip/gic-v3: Parse and export virtual GIC information

Show all headers | View raw

On 09/04/16 03:29, Shanker Donthineni wrote:
> Hi Julien,

Hello Shanker,

> On 04/04/2016 06:37 AM, Julien Grall wrote:
>> +static int __init gic_acpi_parse_virt_madt_gicc(struct
>> acpi_subtable_header *header,
>> +						const unsigned long end)
>> +{
>> +	struct acpi_madt_generic_interrupt *gicc =
>> +		(struct acpi_madt_generic_interrupt *)header;
>> +	int maint_irq_mode;
>> +	static int first_madt = true;
>> +
>> +	maint_irq_mode = (gicc->flags & ACPI_MADT_VGIC_IRQ_MODE) ?
>> +		ACPI_EDGE_SENSITIVE : ACPI_LEVEL_SENSITIVE;
>> +
> Do you think GICC parameters are valid for an unusable processor?

Good point. We don't know if the value will be valid when the processor 
is unusable.

> If not we need a validation check here, some thing like this to skip
> GICC subtable entry.
>
>              if (!(gicc->flags & ACPI_MADT_ENABLED))
>                  return 0;

I will add this check.

Regards,

-- 
Julien Grall

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5 0/9] arm64: Add support for KVM with ACPI Julien Grall <julien.grall@arm.com> - 2016-04-04 13:40 +0200
  [PATCH v5 7/9] KVM: arm/arm64: arch_timer: Rely on the arch timer to parse the firmware tables Julien Grall <julien.grall@arm.com> - 2016-04-04 13:40 +0200
  [PATCH v5 3/9] irqchip/gic-v2: Gather ACPI specific data in a single structure Julien Grall <julien.grall@arm.com> - 2016-04-04 13:40 +0200
    Re: [PATCH v5 3/9] irqchip/gic-v2: Gather ACPI specific data in a  single structure Hanjun Guo <hanjun.guo@linaro.org> - 2016-04-11 04:50 +0200
  [PATCH v5 2/9] clocksource: arm_arch_timer: Extend arch_timer_kvm_info to get the virtual IRQ Julien Grall <julien.grall@arm.com> - 2016-04-04 13:40 +0200
    Re: [PATCH v5 2/9] clocksource: arm_arch_timer: Extend  arch_timer_kvm_info to get the virtual IRQ Christoffer Dall <christoffer.dall@linaro.org> - 2016-04-06 19:30 +0200
  [PATCH v5 8/9] KVM: arm/arm64: vgic: Rely on the GIC driver to parse the firmware tables Julien Grall <julien.grall@arm.com> - 2016-04-04 13:40 +0200
    Re: [PATCH v5 8/9] KVM: arm/arm64: vgic: Rely on the GIC driver to  parse the firmware tables Christoffer Dall <christoffer.dall@linaro.org> - 2016-04-06 19:30 +0200
  [PATCH v5 9/9] clocksource: arm_arch_timer: Remove arch_timer_get_timecounter Julien Grall <julien.grall@arm.com> - 2016-04-04 13:40 +0200
  [PATCH v5 6/9] irqchip/gic-v3: Parse and export virtual GIC information Julien Grall <julien.grall@arm.com> - 2016-04-04 13:40 +0200
    Re: [PATCH v5 6/9] irqchip/gic-v3: Parse and export virtual GIC  information Christoffer Dall <christoffer.dall@linaro.org> - 2016-04-06 19:30 +0200
      Re: [PATCH v5 6/9] irqchip/gic-v3: Parse and export virtual GIC  information Julien Grall <julien.grall@arm.com> - 2016-04-06 19:50 +0200
    Re: [PATCH v5 6/9] irqchip/gic-v3: Parse and export virtual GIC  information Shanker Donthineni <shankerd@codeaurora.org> - 2016-04-09 04:30 +0200
      Re: [PATCH v5 6/9] irqchip/gic-v3: Parse and export virtual GIC  information Julien Grall <julien.grall@arm.com> - 2016-04-11 16:10 +0200
    Re: [PATCH v5 6/9] irqchip/gic-v3: Parse and export virtual GIC  information Hanjun Guo <hanjun.guo@linaro.org> - 2016-04-11 07:30 +0200
      Re: [PATCH v5 6/9] irqchip/gic-v3: Parse and export virtual GIC  information Julien Grall <julien.grall@arm.com> - 2016-04-11 16:30 +0200
        Re: [PATCH v5 6/9] irqchip/gic-v3: Parse and export virtual GIC  information Shanker Donthineni <shankerd@codeaurora.org> - 2016-04-11 17:30 +0200
          Re: [PATCH v5 6/9] irqchip/gic-v3: Parse and export virtual GIC  information Hanjun Guo <hanjun.guo@linaro.org> - 2016-04-13 12:20 +0200
  [PATCH v5 4/9] irqchip/gic-v2: Parse and export virtual GIC information Julien Grall <julien.grall@arm.com> - 2016-04-04 13:40 +0200
    Re: [PATCH v5 4/9] irqchip/gic-v2: Parse and export virtual GIC  information Christoffer Dall <christoffer.dall@linaro.org> - 2016-04-06 19:10 +0200
      Re: [PATCH v5 4/9] irqchip/gic-v2: Parse and export virtual GIC  information Julien Grall <julien.grall@arm.com> - 2016-04-06 19:50 +0200
    Re: [PATCH v5 4/9] irqchip/gic-v2: Parse and export virtual GIC  information Hanjun Guo <hanjun.guo@linaro.org> - 2016-04-11 05:20 +0200
      Re: [PATCH v5 4/9] irqchip/gic-v2: Parse and export virtual GIC  information Julien Grall <julien.grall@arm.com> - 2016-04-11 16:00 +0200
  [PATCH v5 1/9] clocksource: arm_arch_timer: Gather KVM specific information in a structure Julien Grall <julien.grall@arm.com> - 2016-04-04 13:50 +0200
    Re: [PATCH v5 1/9] clocksource: arm_arch_timer: Gather KVM specific  information in a structure Christoffer Dall <christoffer.dall@linaro.org> - 2016-04-06 19:30 +0200
  Re: [PATCH v5 0/9] arm64: Add support for KVM with ACPI Christoffer Dall <christoffer.dall@linaro.org> - 2016-04-06 19:30 +0200
    Re: [PATCH v5 0/9] arm64: Add support for KVM with ACPI Julien Grall <julien.grall@arm.com> - 2016-04-06 20:00 +0200

csiph-web