Re: [PATCH] drivers/usb/gadget/udc/r8a66597-udc.c: Deinline pipe_change, save 2176 bytes

From	Felipe Balbi <felipe.balbi@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drivers/usb/gadget/udc/r8a66597-udc.c: Deinline pipe_change, save 2176 bytes
Date	2016-04-11 10:30 +0200
Message-ID	<rmFon-2Ng-33@gated-at.bofh.it> (permalink)
References	<rlKJs-qD-17@gated-at.bofh.it> <rmCAa-Bo-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi again,

Felipe Balbi <felipe.balbi@linux.intel.com> writes:
> Denys Vlasenko <dvlasenk@redhat.com> writes:
>> This function compiles to 298 bytes of machine code, has ~10 callsites.
>
> fair enough
>
>> This is a USB 2.0 device, USB 2.0 is limited to 35 MB/s, so should be
>
> it's not limited to 35MB/sec, sorry. USB 2.0 has a theoretical maximum
> of 60MB/sec. But 44MB/sec is what people consider 'possible'. I've
> gotten to 41MB/sec with g_mas_storage gadget.

also, you need to break you commit log lines at 72 characters. Please,
fix and resend

-- 
balbi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] drivers/usb/gadget/udc/r8a66597-udc.c: Deinline pipe_change, save 2176 bytes Denys Vlasenko <dvlasenk@redhat.com> - 2016-04-08 22:00 +0200
  Re: [PATCH] drivers/usb/gadget/udc/r8a66597-udc.c: Deinline pipe_change, save 2176 bytes Felipe Balbi <felipe.balbi@linux.intel.com> - 2016-04-11 07:30 +0200
    Re: [PATCH] drivers/usb/gadget/udc/r8a66597-udc.c: Deinline pipe_change, save 2176 bytes Felipe Balbi <felipe.balbi@linux.intel.com> - 2016-04-11 10:30 +0200

csiph-web