[PATCH 12/22] mm, page_alloc: Remove unnecessary initialisation from __alloc_pages_nodemask()

From	Mel Gorman <mgorman@techsingularity.net>
Newsgroups	linux.kernel
Subject	[PATCH 12/22] mm, page_alloc: Remove unnecessary initialisation from __alloc_pages_nodemask()
Date	2016-04-11 10:20 +0200
Message-ID	<rmFeH-2HC-43@gated-at.bofh.it> (permalink)
References	<rmFeF-2HC-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

page is guaranteed to be set before it is read with or without the
initialisation.

Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
---
 mm/page_alloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index f5ddb342c967..df03ccc7f07c 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -3348,7 +3348,7 @@ __alloc_pages_nodemask(gfp_t gfp_mask, unsigned int order,
 			struct zonelist *zonelist, nodemask_t *nodemask)
 {
 	struct zoneref *preferred_zoneref;
-	struct page *page = NULL;
+	struct page *page;
 	unsigned int cpuset_mems_cookie;
 	unsigned int alloc_flags = ALLOC_WMARK_LOW|ALLOC_FAIR;
 	gfp_t alloc_mask; /* The gfp_t that was actually used for allocation */
-- 
2.6.4

Thread

[PATCH 00/21] Optimise page alloc/free fast paths Mel Gorman <mgorman@techsingularity.net> - 2016-04-11 10:20 +0200
  [PATCH 08/22] mm, page_alloc: Convert alloc_flags to unsigned Mel Gorman <mgorman@techsingularity.net> - 2016-04-11 10:20 +0200
  [PATCH 04/22] mm, page_alloc: Inline zone_statistics Mel Gorman <mgorman@techsingularity.net> - 2016-04-11 10:20 +0200
  [PATCH 21/22] cpuset: use static key better and convert to new API Mel Gorman <mgorman@techsingularity.net> - 2016-04-11 10:20 +0200
  [PATCH 11/22] mm, page_alloc: Remove unnecessary initialisation in get_page_from_freelist Mel Gorman <mgorman@techsingularity.net> - 2016-04-11 10:20 +0200
  [PATCH 14/22] mm, page_alloc: Simplify last cpupid reset Mel Gorman <mgorman@techsingularity.net> - 2016-04-11 10:20 +0200
  [PATCH 13/22] mm, page_alloc: Remove redundant check for empty zonelist Mel Gorman <mgorman@techsingularity.net> - 2016-04-11 10:20 +0200
  [PATCH 09/22] mm, page_alloc: Convert nr_fair_skipped to bool Mel Gorman <mgorman@techsingularity.net> - 2016-04-11 10:20 +0200
  [PATCH 15/22] mm, page_alloc: Move might_sleep_if check to the allocator slowpath Mel Gorman <mgorman@techsingularity.net> - 2016-04-11 10:20 +0200
  [PATCH 20/22] mm, page_alloc: Check multiple page fields with a single branch Mel Gorman <mgorman@techsingularity.net> - 2016-04-11 10:20 +0200
  [PATCH 12/22] mm, page_alloc: Remove unnecessary initialisation from __alloc_pages_nodemask() Mel Gorman <mgorman@techsingularity.net> - 2016-04-11 10:20 +0200
  [PATCH 19/22] mm, page_alloc: Avoid looking up the first zone in a zonelist twice Mel Gorman <mgorman@techsingularity.net> - 2016-04-11 10:20 +0200
  [PATCH 05/22] mm, page_alloc: Inline the fast path of the zonelist iterator Mel Gorman <mgorman@techsingularity.net> - 2016-04-11 10:20 +0200
  [PATCH 02/22] mm, page_alloc: Use new PageAnonHead helper in the free page fast path Mel Gorman <mgorman@techsingularity.net> - 2016-04-11 10:20 +0200
  [PATCH 16/22] mm, page_alloc: Move __GFP_HARDWALL modifications out of the fastpath Mel Gorman <mgorman@techsingularity.net> - 2016-04-11 10:20 +0200
  [PATCH 17/22] mm, page_alloc: Reduce cost of fair zone allocation policy retry Mel Gorman <mgorman@techsingularity.net> - 2016-04-11 10:20 +0200
  [PATCH 18/22] mm, page_alloc: Shortcut watermark checks for order-0 pages Mel Gorman <mgorman@techsingularity.net> - 2016-04-11 10:30 +0200
  Re: [PATCH 00/21] Optimise page alloc/free fast paths Mel Gorman <mgorman@techsingularity.net> - 2016-04-11 10:30 +0200
  [PATCH 06/22] mm, page_alloc: Use __dec_zone_state for order-0 page allocation Mel Gorman <mgorman@techsingularity.net> - 2016-04-11 10:30 +0200
  [PATCH 10/22] mm, page_alloc: Remove unnecessary local variable in get_page_from_freelist Mel Gorman <mgorman@techsingularity.net> - 2016-04-11 10:30 +0200
  [PATCH 07/22] mm, page_alloc: Avoid unnecessary zone lookups during pageblock operations Mel Gorman <mgorman@techsingularity.net> - 2016-04-11 10:30 +0200
  [PATCH 01/22] mm, page_alloc: Only check PageCompound for high-order pages Mel Gorman <mgorman@techsingularity.net> - 2016-04-11 10:40 +0200
  [PATCH 03/22] mm, page_alloc: Reduce branches in zone_statistics Mel Gorman <mgorman@techsingularity.net> - 2016-04-11 10:40 +0200

csiph-web