Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1375642

Re: [PATCH v2 3/3] mfd: mt6397: check the EPROBE_DEFER from platform_get_irq.

From Lee Jones <lee.jones@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH v2 3/3] mfd: mt6397: check the EPROBE_DEFER from platform_get_irq.
Date 2016-04-11 11:00 +0200
Message-ID <rmFRp-2Ze-29@gated-at.bofh.it> (permalink)
References <rlyyC-8iG-11@gated-at.bofh.it> <rlyIi-bh-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, 08 Apr 2016, Henry Chen wrote:

> If get the -EPROBE_DEFER from platform_get_irq, it should return back directly.
> 
> Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
> ---
>  drivers/mfd/mt6397-core.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
> index 15050cb..b9b1e28 100644
> --- a/drivers/mfd/mt6397-core.c
> +++ b/drivers/mfd/mt6397-core.c
> @@ -271,6 +271,8 @@ static int mt6397_probe(struct platform_device *pdev)
>  	}
>  
>  	pmic->irq = platform_get_irq(pdev, 0);
> +	if (pmic->irq == -EPROBE_DEFER)
> +		return -EPROBE_DEFER;

if (ret < 0)
   return ret;

... is more common, as it covers more bases, etc.

>  	switch (id & 0xff) {
>  	case MT6323_CID_CODE:

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 1/3] mfd: mt6397: irq domain should initialize before mfd_add_devices() Henry Chen <henryc.chen@mediatek.com> - 2016-04-08 09:00 +0200
  [PATCH v2 3/3] mfd: mt6397: check the EPROBE_DEFER from platform_get_irq. Henry Chen <henryc.chen@mediatek.com> - 2016-04-08 09:10 +0200
    Re: [PATCH v2 3/3] mfd: mt6397: check the EPROBE_DEFER from  platform_get_irq. Lee Jones <lee.jones@linaro.org> - 2016-04-11 11:00 +0200
      Re: [PATCH v2 3/3] mfd: mt6397: check the EPROBE_DEFER from  platform_get_irq. Henry Chen <henryc.chen@mediatek.com> - 2016-04-13 07:50 +0200
  [PATCH v2 2/3] mfd: mt6397: Checking for null before irq_domain_remove. Henry Chen <henryc.chen@mediatek.com> - 2016-04-08 09:10 +0200
    Re: [PATCH v2 2/3] mfd: mt6397: Checking for null before  irq_domain_remove. Lee Jones <lee.jones@linaro.org> - 2016-04-11 11:00 +0200
  Re: [PATCH v2 1/3] mfd: mt6397: irq domain should initialize before  mfd_add_devices() Lee Jones <lee.jones@linaro.org> - 2016-04-11 11:00 +0200

csiph-web