[patch] iommu/amd: Signedness bug in acpihid_device_group()

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	[patch] iommu/amd: Signedness bug in acpihid_device_group()
Date	2016-04-11 09:20 +0200
Message-ID	<rmEiD-1Ws-35@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

"devid" needs to be signed for the error handling to work.

Fixes:b097d11a0fa3f ('iommu/amd: Manage iommu_group for ACPI HID devices')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
index c430c10..12f7779 100644
--- a/drivers/iommu/amd_iommu.c
+++ b/drivers/iommu/amd_iommu.c
@@ -283,7 +283,7 @@ static struct iommu_dev_data *get_dev_data(struct device *dev)
 static struct iommu_group *acpihid_device_group(struct device *dev)
 {
 	struct acpihid_map_entry *p, *entry = NULL;
-	u16 devid;
+	int devid;
 
 	devid = get_acpihid_device_id(dev, &entry);
 	if (devid < 0)

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[patch] iommu/amd: Signedness bug in acpihid_device_group() Dan Carpenter <dan.carpenter@oracle.com> - 2016-04-11 09:20 +0200
  RE: [patch] iommu/amd: Signedness bug in acpihid_device_group() "Wan, Vincent" <Vincent.Wan@amd.com> - 2016-04-11 09:30 +0200
  Re: [patch] iommu/amd: Signedness bug in acpihid_device_group() Joerg Roedel <joro@8bytes.org> - 2016-04-11 16:20 +0200

csiph-web