Re: [PATCH 3.14 75/76] perf/x86/intel: Use PAGE_SIZE for PEBS buffer size on Core2

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Jiri Slaby <jslaby@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3.14 75/76] perf/x86/intel: Use PAGE_SIZE for PEBS buffer size on Core2
Date	Mon, 11 Apr 2016 09:10:01 +0200
Message-ID	<rmE8V-1RJ-3@gated-at.bofh.it> (permalink)
References	<rmt3R-1mn-43@gated-at.bofh.it> <rmtdw-1rq-9@gated-at.bofh.it>
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=xr08QiXqg/lcaDHC2oEtNBuG9vEqcaHJof6qCrzNvQE=; b=fjZPYzvMFP9cJ1Wn/lbo9xKziMA5TpWxNYh1UR1H8IQfDWTyfWPfbR/3mNqVGGg9/C Pw6P0CbodEG185lEwCJfSHQB7VbenEVkSte4vsBU6QsH5ND+8fiKTndlP2nE8LR7jd5/ bwAabY7rMVTTFM+j3Aa9FVrxg6CayjWb8Ms9ZsU6ZqI5IsgNT/3LPKO5lbzIwRPcgRBs I4CaH0B/XR4LAAdudzl8/h4hc4WpG+pAftEKLnvPawN8pX0zngvR2j9nYSP7BfZ5X+U0 DGXYx+1tHUMo97gucFclc8kJkjCacMRJS2nLYOkRkZ8KMyEp1oOajBH+juuCaaI/jrOz vF3Q==
X-Gm-Message-State	AD7BkJJ/N/FlBT/BmwH3rT7z84sTrCWlf2/4cA2kwG55hsr0hy1E0AG+d2Guerue04eWvw==
X-Received	by 10.28.61.8 with SMTP id k8mr16970901wma.7.1460358096513; Mon, 11 Apr 2016 00:01:36 -0700 (PDT)
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	54
Organization	linux.* mail to news gateway
X-Original-Cc	stable@vger.kernel.org, Arnaldo Carvalho de Melo <acme@redhat.com>, Jiri Olsa <jolsa@kernel.org>, "Peter Zijlstra (Intel)" <peterz@infradead.org>, Andi Kleen <ak@linux.intel.com>, Alexander Shishkin <alexander.shishkin@linux.intel.com>, Jiri Olsa <jolsa@redhat.com>, Kan Liang <kan.liang@intel.com>, Linus Torvalds <torvalds@linux-foundation.org>, Stephane Eranian <eranian@google.com>, Thomas Gleixner <tglx@linutronix.de>, Vince Weaver <vincent.weaver@maine.edu>, Wang Nan <wangnan0@huawei.com>, Ingo Molnar <mingo@kernel.org>
X-Original-Date	Mon, 11 Apr 2016 09:01:33 +0200
X-Original-Message-ID	<570B4BCD.1020403@suse.cz>
X-Original-References	<20160410183516.090999097@linuxfoundation.org> <20160410183518.804821365@linuxfoundation.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1375530

Show key headers only | View raw

On 04/10/2016, 08:37 PM, Greg Kroah-Hartman wrote:
> 3.14-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Jiri Olsa <jolsa@redhat.com>
> 
> commit 3135a66b768c5ee84c8a98b21d0330dc1c1234b4 upstream.

Where does this come from?

fatal: bad object 3135a66b768c5ee84c8a98b21d0330dc1c1234b4

The same for the later perf patch.

> Using PAGE_SIZE buffers makes the WRMSR to PERF_GLOBAL_CTRL in
> intel_pmu_enable_all() mysteriously hang on Core2. As a workaround, we
> don't do this.
> 
> The hard lockup is easily triggered by running 'perf test attr'
> repeatedly. Most of the time it gets stuck on sample session with
> small periods.
> 
>   # perf test attr -vv
>   14: struct perf_event_attr setup                             :
>   --- start ---
>   ...
>     'PERF_TEST_ATTR=/tmp/tmpuEKz3B /usr/bin/perf record -o /tmp/tmpuEKz3B/perf.data -c 123 kill >/dev/null 2>&1' ret 1
> 
> Reported-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> Reviewed-by: Andi Kleen <ak@linux.intel.com>
> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> Cc: Jiri Olsa <jolsa@redhat.com>
> Cc: Kan Liang <kan.liang@intel.com>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Stephane Eranian <eranian@google.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Vince Weaver <vincent.weaver@maine.edu>
> Cc: Wang Nan <wangnan0@huawei.com>
> Link: http://lkml.kernel.org/r/20160301190352.GA8355@krava.redhat.com
> Signed-off-by: Ingo Molnar <mingo@kernel.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>  arch/x86/kernel/cpu/perf_event.h          |    1 +
>  arch/x86/kernel/cpu/perf_event_intel_ds.c |   13 +++++++++++--
>  2 files changed, 12 insertions(+), 2 deletions(-)

thanks,
-- 
js
suse labs

Thread

[PATCH 3.14 75/76] perf/x86/intel: Use PAGE_SIZE for PEBS buffer size on Core2 Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-04-10 21:30 +0200
  Re: [PATCH 3.14 75/76] perf/x86/intel: Use PAGE_SIZE for PEBS buffer  size on Core2 Jiri Slaby <jslaby@suse.cz> - 2016-04-11 09:10 +0200
    Re: [PATCH 3.14 75/76] perf/x86/intel: Use PAGE_SIZE for PEBS buffer  size on Core2 Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-04-12 16:20 +0200

csiph-web