Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1375489

Re: [PATCH 0/2] perf probe fixes for ppc64le

From Michael Ellerman <mpe@ellerman.id.au>
Newsgroups linux.kernel
Subject Re: [PATCH 0/2] perf probe fixes for ppc64le
Date 2016-04-11 06:50 +0200
Message-ID <rmBXs-8ud-3@gated-at.bofh.it> (permalink)
References <rkUUy-3Mo-17@gated-at.bofh.it> <rldku-Vt-11@gated-at.bofh.it> <rleqe-1G9-3@gated-at.bofh.it> <rlyyC-8iG-23@gated-at.bofh.it> <rm1qV-5Qu-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Sat, 2016-04-09 at 19:12 +0530, Naveen N. Rao wrote:
> 
> I suppose this boils down to the quirkiness of ABIv2. Though, in 
> reality, I don't think most users will notice. As I stated above, users 
> will most likely start with the disassembly or debuginfo and this patch 
> ensures there are actually no surprises there.

Yeah it's unfortunate that we have to handle these two cases differently.

But I think you've chosen the right trade off.

When we are just given the name we *must not* use the global entry point,
otherwise the probes will often not hit - because most calls go to the local
entry point and skip the global entry point entirely.

When we're given a name and offset, it's less confusing if we use the global
entry point as the base for the offset calculation.

So for the concept:

Acked-by: Michael Ellerman <mpe@ellerman.id.au>

I don't really know this part of the perf code enough to give you an ack for the
actual changes, I'll leave that to the perf maintainers.

cheers

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] perf probe fixes for ppc64le "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2016-04-06 14:50 +0200
  Re: [PATCH 0/2] perf probe fixes for ppc64le Balbir Singh <bsingharora@gmail.com> - 2016-04-07 10:20 +0200
    Re: [PATCH 0/2] perf probe fixes for ppc64le "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2016-04-07 11:30 +0200
      Re: [PATCH 0/2] perf probe fixes for ppc64le Balbir Singh <bsingharora@gmail.com> - 2016-04-08 09:00 +0200
        Re: [PATCH 0/2] perf probe fixes for ppc64le "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2016-04-09 15:50 +0200
          Re: [PATCH 0/2] perf probe fixes for ppc64le Michael Ellerman <mpe@ellerman.id.au> - 2016-04-11 06:50 +0200
            Re: [PATCH 0/2] perf probe fixes for ppc64le "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2016-04-11 15:50 +0200

csiph-web