Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1374681

Re: [PATCH] x86/vdso: Remove direct HPET access through the vDSO

Show all headers | View raw

On Thu, 7 Apr 2016, Andy Lutomirski wrote:

> Allowing user code to map the HPET is problematic.  HPET
> implementations are notoriously buggy, and there are probably many
> machines on which even MMIO reads from bogus HPET addresses are
> problematic.
> 
> We have a report that the Dell Precision M2800 with:
> 
> ACPI: HPET 0x00000000C8FE6238 000038 (v01 DELL   CBX3  01072009 AMI. 00000005)
> 
> is either so slow when accessing the HPET or actually hangs in some
> regard, causing soft lockups to be reported if users do unexpected
> things to the HPET.
> 
> The vclock HPET code has also always been a questionable speedup.
> Accessing an HPET is exceedingly slow (on the order of several
> microseconds), so the added overhead in requiring a syscall to read
> the HPET is a small fraction of the total code of accessing it.
> 
> To avoid future problems, let's just delete the code entirely.
> 
> In the long run, this could actually be a speedup.  Waiman Long as a
> patch to optimize the case where multiple CPUs contend for the HPET,
> but that won't help unless all the accesses are mediated by the
> kernel.
> 
> Cc: Waiman Long <waiman.long@hpe.com>
> Reported-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> Signed-off-by: Andy Lutomirski <luto@kernel.org>

Reviewed-by: Thomas Gleixner <tglx@linutronix.de>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] x86/vdso: Remove direct HPET access through the vDSO Andy Lutomirski <luto@kernel.org> - 2016-04-08 02:40 +0200
  Re: [PATCH] x86/vdso: Remove direct HPET access through the vDSO Borislav Petkov <bp@alien8.de> - 2016-04-08 12:40 +0200
    Re: [PATCH] x86/vdso: Remove direct HPET access through the vDSO Andy Lutomirski <luto@amacapital.net> - 2016-04-08 18:00 +0200
  Re: [PATCH] x86/vdso: Remove direct HPET access through the vDSO Thomas Gleixner <tglx@linutronix.de> - 2016-04-10 00:50 +0200
  [tip:x86/asm] x86/vdso: Remove direct HPET access through the vDSO tip-bot for Andy Lutomirski <tipbot@zytor.com> - 2016-04-13 13:40 +0200

csiph-web