Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1374053
| From | John Crispin <blogic@openwrt.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH V3 3/8] net: mediatek: remove superfluous reset call |
| Date | 2016-04-08 10:00 +0200 |
| Message-ID | <rlzuG-vj-17@gated-at.bofh.it> (permalink) |
| References | <rlzuG-vj-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
HW reset is triggered in the mtk_hw_init() function. There is no need to also reset the core during probe. Signed-off-by: John Crispin <blogic@openwrt.org> --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c index 94cceb8..a4982e4 100644 --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c @@ -1679,10 +1679,6 @@ static int mtk_probe(struct platform_device *pdev) struct mtk_eth *eth; int err; - err = device_reset(&pdev->dev); - if (err) - return err; - match = of_match_device(of_mtk_match, &pdev->dev); soc = (struct mtk_soc_data *)match->data; -- 1.7.10.4
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH V3 3/8] net: mediatek: remove superfluous reset call John Crispin <blogic@openwrt.org> - 2016-04-08 10:00 +0200
csiph-web